Skip to content

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Jul 11, 2024

Description

This PR aims at displaying an error message in the API form when the link is erroneous/dead/not responding. It would also add a spinning loader for the delay during which the initial requests are made.

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by MEL.

Copy link
Contributor

Affected libs: ui-elements, feature-notifications, feature-catalog, feature-record, feature-router, feature-editor, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: metadata-editor, demo, datahub, webcomponents, map-viewer, search, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 83.789% (-1.3%) from 85.088%
when pulling e902961 on add-error-message-api-form
into cec60ff on main.

Copy link
Contributor

github-actions bot commented Jul 11, 2024

📷 Screenshots are here!

@jahow jahow added the on hold Work has been temporarily halted label Jul 23, 2024
@jahow
Copy link
Member

jahow commented Jul 23, 2024

Currently on hold because of a temporary lack of resources

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on hold Work has been temporarily halted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants