Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add data to webhook #474

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Feature/add data to webhook #474

wants to merge 7 commits into from

Commits on Sep 10, 2024

  1. Add run message and report to webhook message 

    This does increase the message size, though I imagine that's marginal,
and is backwards compatible in that old keys remain in place and
aren't modified. The goal is to make the actual GHC app more set and
forget, and we can handle the errors with a little more discretion on
the webhook end.

The report is being sent as URLEncoded form data, which if we send a
hierarchy just sends a single key. We want the entire report so encode
the JSON as a string and send that. The keys are sorted to make
testing easier.
    Henry Walshaw committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    674c16d View commit details
    Browse the repository at this point in the history

  2. Add responses test requirement

    Henry Walshaw committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    0561e1b View commit details
    Browse the repository at this point in the history

  3. Fix the probe error check 

    Python3 division is always float. Much easier to check if the code is
400 or more.
    Henry Walshaw committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9d25066 View commit details
    Browse the repository at this point in the history

  4. Add recipient to the general fixtures 

    Also update the external links to be https (as otherwise we have to
wait for a bunch of redirects in the tests as well).
    Henry Walshaw committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a1b859e View commit details
    Browse the repository at this point in the history

  5. Add a test to make sure the webhook payload is correct 

    This uses the responses library to intercept the request so we can
confirm that the body content is exactly as expected.
    Henry Walshaw committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    cfeba33 View commit details
    Browse the repository at this point in the history

  6. Fix up the Recipient query 

    Makes sure we're not accidentally doubling up somewhere
    Henry Walshaw committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    48ff5f7 View commit details
    Browse the repository at this point in the history

  7. flake8 fixes

    Henry Walshaw committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    6a152a8 View commit details
    Browse the repository at this point in the history