do not show warnings on missing style name&title#990
Merged
geographika merged 1 commit intogeopython:masterfrom May 22, 2025
Merged
do not show warnings on missing style name&title#990geographika merged 1 commit intogeopython:masterfrom
geographika merged 1 commit intogeopython:masterfrom
Conversation
Contributor
|
This makes sense to me. If both are missing then a warning is still emitted, otherwise title reverts to name if missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning about missing name|title in wms-style clogs our logs, because it is shown on each layer of a wms (if that wms has either key not set). On the other I don't see much value of the warning.
issue improves #987