Support GeoJSON-LD templating #1927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webb-ben
added
enhancement
webb-ben
requested review from
tomkralidis,
doublebyte1 and
a team
and removed request for
tomkralidis and
doublebyte1
|
I would suggest to add at least a basic test for this to make sure that it's not broken by accident in the future. |
Added some general tests for |
tomkralidis
requested changes
Feb 27, 2025
Create `item_list.jsonld` template to backport current /items json-ld content offerings
webb-ben
force-pushed
the
items-template
branch
4 times, most recently
from
c73b5b6 to
ccf5def
Compare
webb-ben
changed the title
|
@tomkralidis ported the JSON-LD templating over to use the HTML template structure. Ready for re-review. |
tomkralidis
approved these changes
Mar 10, 2025
webb-ben
force-pushed
the
items-template
branch
from
f3128b0 to
4f83a7b
Compare
webb-ben
force-pushed
the
items-template
branch
from
4f83a7b to
9fecb89
Compare
This reverts commit 5b371b2.
tomkralidis
approved these changes
Mar 11, 2025
5 tasks
webb-ben
added a commit
to internetofwater/reference.geoconnex.us
that referenced
this pull request
Mar 12, 2025
jwallace94
added a commit
to GeoscienceAustralia/pygeoapi
that referenced
this pull request
Mar 23, 2025
…er (geopython#1953)" This reverts commit 4f90235. Revert "explicitly define init of BaseProvider (geopython#1972)" This reverts commit ee370fb. Revert "Fix conformance class URIs (geopython#1967)" This reverts commit 94b0b3d. Revert "Fix 'type' member of the rel=http://www.opengis.net/def/rel/ogc/1.0/schema link (geopython#1968)" This reverts commit 24dc072. Revert "Update openapi.py (geopython#1966)" This reverts commit 00b1445. Revert "Include JSON-LD documents in manifest (geopython#1963)" This reverts commit b616fb0. Revert "Support GeoJSON-LD templating (geopython#1927)" This reverts commit 9d60950. Revert "- gracefully catch missing tiles in wmts facade (geopython#1960)" This reverts commit 3a9d853. Revert "Directly render EDR JSON in HTML (geopython#1955)" This reverts commit 7168828. Revert "Gracefully catch tile not found (geopython#1937)" This reverts commit f794d67.
webb-ben
added a commit
to internetofwater/reference.geoconnex.us
that referenced
this pull request
Apr 4, 2025
* Remove sitemap * Set Graph endpoint as env variable * Update json-ld template locations implements geopython/pygeoapi#1927 * Delete snap.png * Create terraform deployment for required services * Create terraform deployment for required services * Fix templates * Update pygeoapi.config.yml * Update pygeoapi.config.yml * Condense mainstem query * Limit HTML to only show top 100 graph results * Limit to 100k datasets on a mainstem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Building on the capacity introduced in #868 and #1858, the PR migrates GeoJSON-LD rendering to always use Jinja2 templates. The default templates provide the same functional JSON-LD output as pygeoapi currently outputs. With the addition of dataset level templating, custom JSON-LD can be rendered for an GeoJSON Feature or GeoJSON Feature Collection by implementing the appropriate template.
This allows us to also un-next the
contextblock from a resource configuration, seeeing as the only specific configuration for linked-data is now just the context block.Finally, serialization of geojsonld was moved inside geojson2gejsonld to reduce the number of times the json is serialized and the align with the function's docstring.
Related Issue / discussion
Additional information
In theory it is possible this type of behavior could be subsumed by a jinj2 formatter plugin - not sure how plugin formatters interact with the default HTTP types pygeoapi deals with (HTML, JSON, JSON-LD)
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)