Fix parsing of booleanLiterals in cql2-text#96
Merged
constantinius merged 1 commit intogeopython:mainfrom Jul 8, 2024
Merged
Conversation
Contributor
Author
I ended up opening #97 to bump the pre-commit dependencies. |
antoine-de
added a commit
to antoine-de/pygeofilter
that referenced
this pull request
Aug 29, 2024
For the moment
```python
assert parse("attr = true") == ast.Equal(
ast.Attribute("attr"),
ast.Attribute("true"),
)
```
like geopython#96, use lark terminal
priority to ensure boolean are parsed as such and not as attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses Lark's terminal priority to ensure that
booleanLiteralvalues (case-insensitiveTRUE/FALSE) are parsed as such and not as attributes (which is currently the case).I attempted to run the pre-commit formatters/linters but I could not install
isortusing the version ofpoetrycurrently installed on my system and bumping theisortversion in.pre-commit-config.yamlintroduced some changes to the sorting rules that affected multiple files. I am happy to include updates to the pre-commit dependencies as a sidecar change to this PR or to open a separate PR with those changes.BEGIN_COMMIT_OVERRIDE
fix: Addresses #95.
END_COMMIT_OVERRIDE