Skip to content

Publicize new feature writer structure, so callers can access. #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented May 4, 2025

  • I agree to follow the project's code of conduct.
  • I added an entry to the project's change log file if knowledge of this change could be valuable to users.
    • Usually called CHANGES.md or CHANGELOG.md
    • Prefix changelog entries for breaking changes with "BREAKING: "

@frewsxcv frewsxcv requested a review from michaelkirk May 4, 2025 02:49
@frewsxcv frewsxcv changed the title Publicize new feature writier structures, so callers can access. Publicize new feature writer structures, so callers can access. May 4, 2025
@frewsxcv
Copy link
Member Author

frewsxcv commented May 4, 2025

@michaelkirk I incorporated the feature reading functionality in rgis (frewsxcv/rgis@5142788) and it works great! Thanks again for adding it

@michaelkirk
Copy link
Member

Can you explain why you want to do this given the existing implementation already includes properties, properties_mut, geometry, geometry_mut, and into_inner?

@frewsxcv frewsxcv changed the title Publicize new feature writer structures, so callers can access. Publicize new feature writer structure, so callers can access. May 6, 2025
@frewsxcv
Copy link
Member Author

frewsxcv commented May 6, 2025

Can you explain why you want to do this given the existing implementation already includes properties, properties_mut, geometry, geometry_mut, and into_inner?

I didn't see them! Updated the PR to just include the reexport change

@michaelkirk
Copy link
Member

I didn't see them!

Oh phew. I know some people just don't like the ceremony of getter/setter methods, so I'm relieved to not have to slog through that discussion. 😅

@michaelkirk michaelkirk enabled auto-merge May 6, 2025 18:28
@michaelkirk michaelkirk added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit 970aa4f May 6, 2025
2 checks passed
@michaelkirk michaelkirk deleted the cfarwell-B63F84F8-CC7B-4BA2-A5AC-18248CE4616E branch May 6, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants