Don't overwrite OUT_DIR in build.rs #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pka
changed the title
|
one thing i could never understand is why we would ever want to hack OUT_DIR to output something that is clearly temporary to be checked in. Compiling a protobuf file, esp as simple and well studied as the one used for mvt should not result in a checked-in file - but rather use a standard out_dir on every build, conditional on the .proto file not changing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adressing #254
Since the Protobuf generation function in
build.rsis only called whenvector_tile.rsdoesn't exists, it is effectively never called in a regular build. I'd like to leavebuild.rsin the source tree and at leastOUT_DIRis not overwritten anymore.