Skip to content

chore: bump dependencies #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2025
Merged

chore: bump dependencies #260

merged 3 commits into from
Jun 13, 2025

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Jun 12, 2025

Update many dependencies, and fix up the code to match the changes.

  • I agree to follow the project's code of conduct.
  • I added an entry to the project's change log file if knowledge of this change could be valuable to users.
    • Usually called CHANGES.md or CHANGELOG.md
    • Prefix changelog entries for breaking changes with "BREAKING: "

@nyurik nyurik requested review from michaelkirk, Copilot and pka June 12, 2025 23:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A chore PR to bump various dependencies and align code with updated APIs.

  • Refactored wkt_reader.rs to use new wkt methods (coord, points, line_strings, etc.) instead of tuple fields.
  • Updated benchmarking imports (black_box) and bumped criterion, dbase, gdal, geo, gpx, and wkt versions in Cargo.toml.
  • Added a new ## Dependencies section in README.md with system package install instructions.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
geozero/src/wkt/wkt_reader.rs Replaced direct tuple access (e.g., g.0) with new wkt crate methods for geometry
geozero-bench/benches/mvtbench.rs Moved black_box import to std::hint per Criterion 0.6
README.md Added ## Dependencies section with apt-get instructions
Cargo.toml Bumped versions of several crates (criterion, dbase, gdal, geo, gpx, wkt)
Comments suppressed due to low confidence (3)

geozero/src/wkt/wkt_reader.rs:113

  • [nitpick] Consider reusing the outer multi_dim variable here or renaming multi_dim1 to a more descriptive name (e.g., inner_multi_dim) to improve readability.
let multi_dim1 = processor.multi_dim();

README.md:263

  • [nitpick] Consider adding installation instructions for macOS (e.g., brew install geos gdal) and other common platforms to help users on non-Linux systems.
## Dependencies

Update many dependencies, and fix up the code to match the changes.
Copy link
Member

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nyurik
Copy link
Member Author

nyurik commented Jun 12, 2025

@michaelkirk i also bumped edition to 2024 because now dependencies won't compile without support for that, so makes sense to migrate as well.

@michaelkirk
Copy link
Member

Oh yeah, I didn't see the 2024 update.

In georust/geo we have a minimum 6 months support window, but I don't feel strongly about requiring that here, so I'm OK with merging it if @pka is.

@nyurik
Copy link
Member Author

nyurik commented Jun 12, 2025

@michaelkirk I did not update it initially, but there was no point to keep it back because multiple non-optional dependencies were requiring it - so it's basically either that or we would have to postpone this update 🤷

@nyurik nyurik added this pull request to the merge queue Jun 13, 2025
Merged via the queue into georust:main with commit 9a3539f Jun 13, 2025
1 check passed
@nyurik nyurik deleted the bump branch June 13, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants