-
Notifications
You must be signed in to change notification settings - Fork 46
chore: bump dependencies #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
A chore PR to bump various dependencies and align code with updated APIs.
- Refactored
wkt_reader.rs
to use newwkt
methods (coord
,points
,line_strings
, etc.) instead of tuple fields. - Updated benchmarking imports (
black_box
) and bumpedcriterion
,dbase
,gdal
,geo
,gpx
, andwkt
versions inCargo.toml
. - Added a new
## Dependencies
section inREADME.md
with system package install instructions.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
geozero/src/wkt/wkt_reader.rs | Replaced direct tuple access (e.g., g.0 ) with new wkt crate methods for geometry |
geozero-bench/benches/mvtbench.rs | Moved black_box import to std::hint per Criterion 0.6 |
README.md | Added ## Dependencies section with apt-get instructions |
Cargo.toml | Bumped versions of several crates (criterion , dbase , gdal , geo , gpx , wkt ) |
Comments suppressed due to low confidence (3)
geozero/src/wkt/wkt_reader.rs:113
- [nitpick] Consider reusing the outer
multi_dim
variable here or renamingmulti_dim1
to a more descriptive name (e.g.,inner_multi_dim
) to improve readability.
let multi_dim1 = processor.multi_dim();
README.md:263
- [nitpick] Consider adding installation instructions for macOS (e.g.,
brew install geos gdal
) and other common platforms to help users on non-Linux systems.
## Dependencies
Update many dependencies, and fix up the code to match the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@michaelkirk i also bumped edition to 2024 because now dependencies won't compile without support for that, so makes sense to migrate as well. |
Oh yeah, I didn't see the 2024 update. In |
@michaelkirk I did not update it initially, but there was no point to keep it back because multiple non-optional dependencies were requiring it - so it's basically either that or we would have to postpone this update 🤷 |
Update many dependencies, and fix up the code to match the changes.
CHANGES.md
orCHANGELOG.md