Don't fail parsing on empty coordinates#68
Conversation
|
Thanks for the PR @cappuc! Coordinates are required by the spec but I agree with you that this might be better to sort out on the client side rather than failing to parse so this makes sense. The clippy errors are unrelated to your changes but don’t worry about those. Could you add a test for this though? Then I can take a closer look but seems like it should be good |
|
Hi @pjsier, I added a simple test that doesn't fail with a document with empty coordinates. Do you want to add more tests or is this enough? |
pjsier
left a comment
There was a problem hiding this comment.
Thanks for that update! I think we'll need to tweak the test but once that's updated we should be able to merge
pjsier
left a comment
There was a problem hiding this comment.
Thanks for making that update! This looks great, will merge and cut a new release
CHANGES.mdorCHANGELOG.mdThis change allows the parsing of
kmlfiles with emptycoordinates(this can be checked on client code):I have customers provided
kmlfiles with some validPlacemarkand some invalid (empty coordinates like in the example).Right now I cannot parse the file because it return an error for empty
coordinatesbut this can be safely checked inside client code.