Fix/ Boolean abbreviations get evaluated in keyword context #415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny PR to fix a minor bug with situations where
n, f, y, or t
appear as a keyword in a key-val tuple.Original behavior:
The unit tests:
fail, saying, respectively:
In short, "n" and "y" get normalized even if they are keywords. This gets annoying for example when controlling nProcs settings for decomposition methods is desired...
Suggested solution:
An alternative solution that I haven't had time to try is to dig around
normalize_data/normalize_keyword
to skip normalizing the first element in a tuple but that would be hard to distinguish because of OpenFOAM's ambiguous syntax: without full context, the first "n" in("n" "n")
cannot be judged to be a keyword or a data element.