Skip to content

FEATURE: add AWS VPC CNI IP allocation strategy variables #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025

Conversation

relkli
Copy link
Contributor

@relkli relkli commented Jun 6, 2025

  • Introduced new variable ip_allocation_strategy to manage IP allocation settings.
  • Updated network-plugins.tf to utilize the new allocation strategy variables.
  • Modified aws-vpc-cni.yaml.tpl to conditionally set warm ENI, prefix, and IP targets based on the new variables.

Copilot

This comment was marked as outdated.

@relkli relkli force-pushed the feat/aws-vpc-cni-ip-allocation-strategy branch from 9549e66 to 1b20460 Compare June 6, 2025 06:14
@relkli relkli requested a review from Copilot June 6, 2025 06:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A feature PR that adds new variables to control AWS VPC CNI IP allocation settings.

  • Introduces the aws_vpc_cni_ip_allocation_strategy variable in variables.tf
  • Updates the aws-vpc-cni.yaml.tpl template to conditionally include new environment variables
  • Modifies network-plugins.tf to pass the new allocation strategy values to the YAML template

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
variables.tf Adds a new object variable for AWS VPC CNI IP allocation strategy
templates/network-plugins/amazon-vpc/aws-vpc-cni.yaml.tpl Applies conditional logic to include environment variables based on the new variable
network-plugins.tf Passes the new variable values to the configuration for the CNI YAML generation
Comments suppressed due to low confidence (1)

variables.tf:259

  • Consider adding inline comments for each field within the aws_vpc_cni_ip_allocation_strategy object to clarify their specific usage.
variable "aws_vpc_cni_ip_allocation_strategy" {

- Introduced new variable `ip_allocation_strategy` to manage IP allocation settings.
- Updated `network-plugins.tf` to utilize the new allocation strategy variables.
- Modified `aws-vpc-cni.yaml.tpl` to conditionally set warm ENI, prefix, and IP targets based on the new variables.
@relkli relkli force-pushed the feat/aws-vpc-cni-ip-allocation-strategy branch 3 times, most recently from 2f0149e to b47d202 Compare June 6, 2025 08:14
@relkli relkli force-pushed the feat/aws-vpc-cni-ip-allocation-strategy branch from b47d202 to c0b3091 Compare June 6, 2025 08:16
Copy link
Contributor

@soem soem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@relkli relkli merged commit e7b5f36 into master Jun 6, 2025
2 checks passed
@relkli relkli deleted the feat/aws-vpc-cni-ip-allocation-strategy branch June 6, 2025 09:10
relkli pushed a commit to getamis/vishwakarma that referenced this pull request Jun 6, 2025
… VPC CNI (#194)

- Updated module sources for aws-iam-authenticator,
aws-pod-identity-webhook, kubelet, and ignition_kubernetes to reference
the version.
- Introduced a new variable `ip_allocation_strategy` in kube-master to
configure AWS VPC CNI IP allocation settings.
- getamis/terraform-ignition-kubernetes#90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants