-
Notifications
You must be signed in to change notification settings - Fork 2
FEATURE: add AWS VPC CNI IP allocation strategy variables #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9549e66
to
1b20460
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
A feature PR that adds new variables to control AWS VPC CNI IP allocation settings.
- Introduces the aws_vpc_cni_ip_allocation_strategy variable in variables.tf
- Updates the aws-vpc-cni.yaml.tpl template to conditionally include new environment variables
- Modifies network-plugins.tf to pass the new allocation strategy values to the YAML template
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
variables.tf | Adds a new object variable for AWS VPC CNI IP allocation strategy |
templates/network-plugins/amazon-vpc/aws-vpc-cni.yaml.tpl | Applies conditional logic to include environment variables based on the new variable |
network-plugins.tf | Passes the new variable values to the configuration for the CNI YAML generation |
Comments suppressed due to low confidence (1)
variables.tf:259
- Consider adding inline comments for each field within the aws_vpc_cni_ip_allocation_strategy object to clarify their specific usage.
variable "aws_vpc_cni_ip_allocation_strategy" {
- Introduced new variable `ip_allocation_strategy` to manage IP allocation settings. - Updated `network-plugins.tf` to utilize the new allocation strategy variables. - Modified `aws-vpc-cni.yaml.tpl` to conditionally set warm ENI, prefix, and IP targets based on the new variables.
2f0149e
to
b47d202
Compare
b47d202
to
c0b3091
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… VPC CNI (#194) - Updated module sources for aws-iam-authenticator, aws-pod-identity-webhook, kubelet, and ignition_kubernetes to reference the version. - Introduced a new variable `ip_allocation_strategy` in kube-master to configure AWS VPC CNI IP allocation settings. - getamis/terraform-ignition-kubernetes#90
ip_allocation_strategy
to manage IP allocation settings.network-plugins.tf
to utilize the new allocation strategy variables.aws-vpc-cni.yaml.tpl
to conditionally set warm ENI, prefix, and IP targets based on the new variables.