Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transactionalEmailApi::getTransacBlockedContactsRequest $senders argument conversion #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

franck-grenier
Copy link

@franck-grenier franck-grenier commented Aug 28, 2024

According to documentation (and proven by real test),
/v3/smtp/blockedContacts API endpoint expects a senders param as a comma separated list of emails : https://developers.brevo.com/reference/gettransacblockedcontacts

But, the $senders param is not converted correctly in Brevo\Client\Api\TransactionalEmailsApi::getTransacBlockedContactsRequest and is sent as an array in the request making it fail with a 500 error.

As a fix, we can just pass $senders param in ObjectSerializer::toQueryValue to get the expected comma separated list of emails as a string from an array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant