Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for product category search for coupons #1765

Open
wants to merge 2 commits into
base: update/coupon/rewrite
Choose a base branch
from

Conversation

tanmayjay
Copy link
Contributor

@tanmayjay tanmayjay commented Nov 22, 2022

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Part of https://github.com/weDevsOfficial/dokan-pro/pull/2099

Changelog entry

Update: Added support for product category

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

@tanmayjay tanmayjay added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval Dependency With Pro labels Nov 22, 2022
@tanmayjay tanmayjay self-assigned this Nov 22, 2022
@nurul-umbhiya nurul-umbhiya added In Progress The issues is being worked on and removed Needs: Dev Review It requires a developer review and approval labels Dec 1, 2022
@tanmayjay tanmayjay changed the base branch from develop to update/coupon/rewrite March 31, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependency With Pro In Progress The issues is being worked on Needs: Testing This requires further testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants