Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Vendor product review settings display enabled when wooCommerce settings disable. #2198

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

MdAsifHossainNadim
Copy link
Contributor

@MdAsifHossainNadim MdAsifHossainNadim commented Mar 8, 2024

Vendor product review settings appears enabled when wc settings disable.

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included related pull request(s) (optional)
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

Dependency PR Link: #3173

Closes

How to test the changes in this Pull Request:

Issue: #3142

Changelog entry

Fix: Make vendor product review settings hide/invisible when wc review settings disabled.

Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Fixes Video: Link

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

@MdAsifHossainNadim MdAsifHossainNadim added the In Progress The issues is being worked on label Mar 8, 2024
@MdAsifHossainNadim MdAsifHossainNadim self-assigned this Mar 8, 2024
@MdAsifHossainNadim MdAsifHossainNadim added Type: Bug Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval and removed In Progress The issues is being worked on Type: Bug labels Mar 8, 2024
@MdAsifHossainNadim MdAsifHossainNadim changed the title fix/vendor-product-review-settings-display-enabled-when-wc-settings-disable Fix: Vendor product review settings display enabled when wc settings disable Mar 21, 2024
@MdAsifHossainNadim MdAsifHossainNadim changed the title Fix: Vendor product review settings display enabled when wc settings disable Fix: Vendor product review settings display enabled when wooCommerce settings disable. Mar 21, 2024
@MdAsifHossainNadim MdAsifHossainNadim requested review from aihimel and removed request for nurul-umbhiya April 3, 2024 04:56
@MdAsifHossainNadim
Copy link
Contributor Author

@aihimel Vhai, kindly review this PR at your convenience.

@MdAsifHossainNadim MdAsifHossainNadim removed the request for review from aihimel April 18, 2024 10:01
@MdAsifHossainNadim MdAsifHossainNadim added DO NOT MERGE Don't merge this PR and removed Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval Upcoming Release labels Apr 18, 2024
@MdAsifHossainNadim
Copy link
Contributor Author

MdAsifHossainNadim commented Apr 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants