-
Notifications
You must be signed in to change notification settings - Fork 215
Sync vendor coupon distribution with commission and commission subsidy. #2563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mrabbani
merged 134 commits into
revamp/coupon
from
feat/sync-vendor-coupon-distribution-with-commission
May 2, 2025
Merged
Sync vendor coupon distribution with commission and commission subsidy. #2563
mrabbani
merged 134 commits into
revamp/coupon
from
feat/sync-vendor-coupon-distribution-with-commission
May 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create simple test case for coupon apply
This comment was marked as off-topic.
This comment was marked as off-topic.
…' into feat/adjust-commision-for-refund
refactor: Lazy load next strategy
* feat: Add `VendorBalanceUpdateHandler` to manage vendor balance updates on order edits * fix: Improve error handling in `VendorBalanceUpdateHandler` for balance updates on order edits
* refactor: remove unnecessary line change in create_commission method * fix: ensure settings are retrieved from eligible strategy without null safety operator * fix: remove null safety operator for eligible strategy retrieval * fix: add null checks for eligible strategy retrieval in get_settings and get_next methods
…2689) * added test cases, commission type from_vendor, shared, with refund, * added partial refund, fixed product test cases
* fix: prevent refund adjustment in order commission calculation * refactor: streamline commission calculation methods and add refund handling
…nnecessary parameters
…ndor Fix the Setting model
Feat/adjust commision for refund
danielbreves
reviewed
Oct 4, 2025
| $gateway_fee = $this->order->get_meta( 'dokan_gateway_fee', true ); | ||
| $gateway_fee_paid_by = $this->order->get_meta( 'dokan_gateway_fee_paid_by', true ); | ||
|
|
||
| if ( ! empty( $processing_fee ) && empty( $gateway_fee_paid_by ) ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bump Version
Select for the next major version release
Needs: Dev Review
It requires a developer review and approval
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Update commission calculation.
Related Pull Request(s)
Closes
How to test the changes in this Pull Request:
Changelog entry
Title