Skip to content

Conversation

@Aunshon
Copy link
Collaborator

@Aunshon Aunshon commented Feb 10, 2025

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included related pull request(s) (optional)
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Update commission calculation.

Related Pull Request(s)

Closes

How to test the changes in this Pull Request:

  • Steps or issue link

Changelog entry

Title

@coderabbitai

This comment was marked as off-topic.

coderabbitai[bot]

This comment was marked as off-topic.

coderabbitai[bot]

This comment was marked as off-topic.

@Aunshon Aunshon changed the base branch from develop to feat/vendor-coupon-distribution February 11, 2025 10:49
@Aunshon Aunshon self-assigned this Feb 12, 2025
@Aunshon Aunshon changed the title feat/sync-vendor-coupon-distribution-with-commission Sync vendor coupon distribution with commission and commission subsidy. Mar 3, 2025
@Aunshon Aunshon added the In Progress The issues is being worked on label Mar 3, 2025
@mrabbani mrabbani added the Bump Version Select for the next major version release label Mar 4, 2025
mrabbani and others added 26 commits April 28, 2025 09:07
* feat: Add `VendorBalanceUpdateHandler` to manage vendor balance updates on order edits

* fix: Improve error handling in `VendorBalanceUpdateHandler` for balance updates on order edits
* refactor: remove unnecessary line change in create_commission method

* fix: ensure settings are retrieved from eligible strategy without null safety operator

* fix: remove null safety operator for eligible strategy retrieval

* fix: add null checks for eligible strategy retrieval in get_settings and get_next methods
…2689)

* added test cases, commission type from_vendor, shared, with refund,

* added partial refund, fixed product test cases
* fix: prevent refund adjustment in order commission calculation

* refactor: streamline commission calculation methods and add refund handling
@mrabbani mrabbani merged commit 3076daa into revamp/coupon May 2, 2025
1 check failed
@mrabbani mrabbani deleted the feat/sync-vendor-coupon-distribution-with-commission branch May 2, 2025 09:46
$gateway_fee = $this->order->get_meta( 'dokan_gateway_fee', true );
$gateway_fee_paid_by = $this->order->get_meta( 'dokan_gateway_fee_paid_by', true );

if ( ! empty( $processing_fee ) && empty( $gateway_fee_paid_by ) ) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aunshon @mrabbani @kzamanbd should this be $gateway_fee instead of $processing_fee?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bump Version Select for the next major version release Needs: Dev Review It requires a developer review and approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants