-
Notifications
You must be signed in to change notification settings - Fork 215
callback Mapper Admin Settings in progress #3015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enhance/map-all-the-settings-storage-key-based-on-settings-mapper
Are you sure you want to change the base?
callback Mapper Admin Settings in progress #3015
Conversation
…rage-key-based-on-settings-mapper' into enhance/new-admin-settings-fixing-and-e2e-testing the commit.
…d fixing this page bugs
…xing-and-e2e-testing
> marketplace settings
…ttings tests - Add new 'checkbox' field type to adminSettingsPageNew.ts to handle DOM elements with 'enabled' class - Update selector logic to click on visible label while checking state from hidden input element - Add Enable Single Seller Mode field to old dataset in generalMarketplace.spec.ts - Update test values and selectors for marketplace settings synchronization testing - Add debug logging for checkbox state verification
- Fix async iteration by replacing forEach with for...of loop to properly await operations - Increase element visibility timeout from 10s to 15s for old admin page - Add explicit wait for element attachment before scrolling - Improve page stabilization with longer waits for old admin interface - Add conditional navigation check to prevent unnecessary operations Resolves timeout errors: - TimeoutError on #dokan_settings_general selector - Test ended error due to unwaited async operations
- Add reloadUrl method to AdminSettingsPageNew for forced page reload - Fix missing await statements in updateSettings method - Remove unnecessary waitForTimeout calls to improve test speed - Restructure General settings migration test with two separate tests: * Test 1: New settings to old settings synchronization * Test 2: Old settings to new settings synchronization - Optimize element visibility checks and navigation timing This improves test reliability and reduces overall test execution time.
…ngs-mapper' into enhance/new-admin-settings-fixing-and-e2e-testing
…endor to seller as old page
… transaction withdraw page
…ngs-mapper' into enhance/new-admin-settings-fixing-and-e2e-testing
…ngs-mapper' into enhance/new-admin-settings-fixing-and-e2e-testing
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
All Submissions:
Changes proposed in this Pull Request:
Related Pull Request(s)
Closes
How to test the changes in this Pull Request:
Changelog entry
Title
Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.
Before Changes
Describe the issue before changes with screenshots(s).
After Changes
Describe the issue after changes with screenshot(s).
Feature Video (optional)
Link of detailed video if this PR is for a feature.
PR Self Review Checklist:
FOR PR REVIEWER ONLY: