Skip to content

Conversation

@Shamim-97
Copy link
Contributor

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included related pull request(s) (optional)
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

  • Full PR Link

Closes

  • Closes #

How to test the changes in this Pull Request:

  • Steps or issue link

Changelog entry

Title

Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Describe the issue after changes with screenshot(s).

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

akzmoudud and others added 30 commits October 1, 2025 14:35
…rage-key-based-on-settings-mapper' into enhance/new-admin-settings-fixing-and-e2e-testing

 the commit.
> marketplace settings
…ttings tests

- Add new 'checkbox' field type to adminSettingsPageNew.ts to handle DOM elements with 'enabled' class
- Update selector logic to click on visible label while checking state from hidden input element
- Add Enable Single Seller Mode field to old dataset in generalMarketplace.spec.ts
- Update test values and selectors for marketplace settings synchronization testing
- Add debug logging for checkbox state verification
- Fix async iteration by replacing forEach with for...of loop to properly await operations
- Increase element visibility timeout from 10s to 15s for old admin page
- Add explicit wait for element attachment before scrolling
- Improve page stabilization with longer waits for old admin interface
- Add conditional navigation check to prevent unnecessary operations

Resolves timeout errors:
- TimeoutError on #dokan_settings_general selector
- Test ended error due to unwaited async operations
- Add reloadUrl method to AdminSettingsPageNew for forced page reload
- Fix missing await statements in updateSettings method
- Remove unnecessary waitForTimeout calls to improve test speed
- Restructure General settings migration test with two separate tests:
  * Test 1: New settings to old settings synchronization
  * Test 2: Old settings to new settings synchronization
- Optimize element visibility checks and navigation timing

This improves test reliability and reduces overall test execution time.
…ngs-mapper' into enhance/new-admin-settings-fixing-and-e2e-testing
…ngs-mapper' into enhance/new-admin-settings-fixing-and-e2e-testing
…ngs-mapper' into enhance/new-admin-settings-fixing-and-e2e-testing
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch callbackMapperAdminSettings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Base automatically changed from enhance/new-admin-settings-fixing-and-e2e-testing to enhance/map-all-the-settings-storage-key-based-on-settings-mapper December 18, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants