-
Notifications
You must be signed in to change notification settings - Fork 215
fix: redirect to vendor list page after creating new vendor #3035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix: redirect to vendor list page after creating new vendor #3035
Conversation
After creating a new vendor from the WordPress admin panel (Admin →
Dokan → Vendor → Add Vendor), clicking the "Add Vendor" button was
redirecting users to the vendor edit page instead of the vendor list
page.
This change updates the redirect behavior in the Create component to
navigate to `/vendors` (vendor list page) instead of `/vendors/edit/{id}`
(edit page) after successful vendor creation.
WalkthroughThis change modifies the redirect behavior in the vendor creation flow. After successfully creating a new vendor, users are now redirected to the vendors list page instead of the newly created vendor's edit page. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This Change needs discussion; it is disrupting the natural flow of record creation. |
After creating a new vendor from the WordPress admin panel (Admin → Dokan → Vendor → Add Vendor), clicking the "Add Vendor" button was redirecting users to the vendor edit page instead of the vendor list page.
This change updates the redirect behavior in the Create component to navigate to
/vendors(vendor list page) instead of/vendors/edit/{id}(edit page) after successful vendor creation.All Submissions:
Changes proposed in this Pull Request:
Fixed the redirect behavior after vendor creation. Previously, after successfully creating a new vendor, users were redirected to the vendor edit page (
/vendors/edit/{id}). This has been changed to redirect to the vendor list page (/vendors) instead, allowing users to see all vendors including the newly created one.Related Pull Request(s)
Closes
How to test the changes in this Pull Request:
Changelog entry
Fix: Redirect to vendor list page after creating new vendor
Fixed the redirect behavior after vendor creation. Previously, after successfully creating a new vendor from the admin panel, users were redirected to the vendor edit page. Now, users are redirected to the vendor list page where they can see all vendors.
Before Changes
After clicking "Add Vendor" button, users were redirected to the vendor edit page instead of the vendor list page.
After Changes
After clicking "Add Vendor" button, users are now redirected to the vendor list page.
Feature Video (optional)
Link of detailed video if this PR is for a feature.
https://www.loom.com/share/cc50ff8a52b74921b0073b4b665c69f4
PR Self Review Checklist:
FOR PR REVIEWER ONLY:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.