Skip to content

v5 Support #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025
Merged

v5 Support #37

merged 1 commit into from
Jun 6, 2025

Conversation

bastianallgeier
Copy link
Member

Changelog

@bastianallgeier bastianallgeier marked this pull request as draft May 28, 2025 09:26
Copy link
Member

@lukasbestle lukasbestle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we ever have different cacheable version IDs besides latest, Staticache could not differentiate between them (the URL and therefore cache path will be the same). So in this case we will need to add a note to the Staticache README about this limitation. But not sure if that already makes sense as it's currently not a problem (we only have latest and changes, the latter not being cacheable).

@bastianallgeier bastianallgeier marked this pull request as ready for review June 4, 2025 18:27
@bastianallgeier bastianallgeier added this to the 2.0.0 milestone Jun 4, 2025
@bastianallgeier bastianallgeier merged commit 31131c7 into main Jun 6, 2025
@bastianallgeier bastianallgeier deleted the v5-support branch June 6, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants