Skip to content

fix(linters): allow prettier to be installed via mise instead of package.json #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malept merged 5 commits into from
May 5, 2025
Merged

fix(linters): allow prettier to be installed via mise instead of package.json #896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
51d0e88
fix(linters): allow prettier to be installed via mise instead of pack…
malept Apr 30, 2025
642863d
Use warn instead of echo
malept May 1, 2025
e51b910
Only look for prettier via mise if there's no package.json
malept May 1, 2025
51a70c5
shfmt
malept May 1, 2025
5e85ec1
Better error message
malept May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions shell/languages/nodejs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,20 @@
#!/usr/bin/env bash
# Helpers for node.js

# shellcheck source=../lib/logging.sh
source "$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)/../lib/logging.sh"

# shellcheck source=../lib/shell.sh
source "$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)/../lib/shell.sh"

yarn_install_if_needed() {
local stateFile="node_modules/devbase.lock"

if [[ ! -e "package.json" ]]; then
warn "No package.json found, skipping yarn install"
return
fi

if ! yarn -v >/dev/null 2>&1; then
npm install -g yarn
fi
Expand Down
7 changes: 7 additions & 0 deletions shell/linters/prettier.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@ source "$DIR/languages/nodejs.sh"
extensions=(yaml yml json md ts)

PRETTIER="node_modules/.bin/prettier"
if [[ ! -f $PRETTIER ]] && [[ ! -f package.json ]]; then
# Try to find prettier installed via mise
PRETTIER="$(mise which prettier)"
if [[ -z $PRETTIER ]]; then
fatal "prettier not found in repo, make sure 'npx:prettier' is defined in 'mise.toml' and you have run 'mise install'"
fi
fi

prettier_log_level_flag() {
if [[ $("$PRETTIER" --version) =~ ^2 ]]; then
Expand Down