Upgrade prettier version to the same version that CI is using#7367
Merged
yoshiokatsuneo merged 2 commits intogetredash:masterfrom Jul 17, 2025
Merged
Upgrade prettier version to the same version that CI is using#7367yoshiokatsuneo merged 2 commits intogetredash:masterfrom
yoshiokatsuneo merged 2 commits intogetredash:masterfrom
Conversation
eradman
approved these changes
Jul 17, 2025
Collaborator
eradman
left a comment
eradman
left a comment
There was a problem hiding this comment.
Indeed, there is no reason these versions should not match!
redash$ grep prettier: .restyled.yaml
image: restyled/restyler-prettier:v3.3.2-2
Contributor
Author
|
@eradman Thank you for your review!! |
wtfiwtz
added a commit
to orchestrated-io/redash
that referenced
this pull request
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Now, the prettier version used on CI is different from the local version defined in package.json . This make quite difficult and annoying to fix the error reported by CI, as local prettier does not fix the error reported by CI.
This PR upgrade prettier to the same version(3.3.2) that CI is using.
How is this tested?
There is no error on "yarn prettier"