Skip to content

Improve UX: sortable Created-by column + avatars #7425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zachliu
Copy link
Contributor

@zachliu zachliu commented Apr 29, 2025

What type of PR is this?

  • Feature

Description

It would be better if the "Created By" column on the query list page were also sortable. This would allow users to quickly locate queries by the author's name. Our support engineers have found this feature particularly helpful.

How is this tested?

  • Manually

Created By is sortable with proper icons/headshots and width

created_by

Related Tickets & Documents

#7117

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@zachliu zachliu mentioned this pull request Apr 30, 2025
2 tasks
@eradman
Copy link
Collaborator

eradman commented Apr 30, 2025

@zachliu this commit should not have 15 commits... compare with master and try git push -f again

for better UX such as finding the query authors
@zachliu zachliu force-pushed the make-created-by-sortable branch from b37e68e to a266756 Compare April 30, 2025 13:35
@zachliu
Copy link
Contributor Author

zachliu commented Apr 30, 2025

@zachliu this commit should not have 15 commits... compare with master and try git push -f again

@eradman apologize, i must have clicked the silly "sync fork" button 😅 it's cleaned up now

Copy link
Collaborator

@eradman eradman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to display the profile image along with the profile name.
I'm not sure we want to make this change, but if we do it should be in a separate PR

@zachliu
Copy link
Contributor Author

zachliu commented Apr 30, 2025

@eradman Sure, I can create a separate PR. However, the whole point of this change is to improve the user experience by helping users quickly identify query authors. Both making the column sortable and showing the profile image contribute to that goal.

Maybe I can rename the PR to "Improved 'Created By' column" to reflect the broader intent with two separate commits?

@zachliu zachliu changed the title Make created by sortable Improve UX: sortable Created-by column + avatars May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants