Fix unexpected /app shadowing in compose.yaml (#7433) #7434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paths within the container got overwritten by volume mount, which caused inconsistencies with the expected contents of directories populated on buid stage. For example, CSS and graphics may not load — see issue getredash#7433.
eradman
reviewed
May 5, 2025
| @@ -5,8 +5,6 @@ x-redash-service: &redash-service | |||
| context: . | |||
| args: | |||
| skip_frontend_build: "true" # set to empty string to build | |||
| volumes: | |||
| - .:/app | |||
There was a problem hiding this comment.
This bindmount is not a mistake, it is required for live-reload in a dev environment
There was a problem hiding this comment.
We need to understand #7433 better. What is the reason for setting skip_frontend_build: ""?
There was a problem hiding this comment.
To avoid skipping of frontend build = force frontend building. Since there is no frontend after cloning the repo, the user needs to build it first.
This is suggested in compose.yml comments
args:
skip_frontend_build: "true" # set to empty string to build
BTW finding this trick was another troubleshooting journey on the way to make it run )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paths within the container got overwritten by volume mount, which caused inconsistencies with the expected contents of directories populated on buid stage.
For example, CSS and graphics may not load — see issue #7433.
What type of PR is this?
Description
How is this tested?
Related Tickets & Documents
#7433
Mobile & Desktop Screenshots/Recordings (if there are UI changes)