Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(producer): Add produce time by topic #423

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

untitaker
Copy link
Member

No description provided.

@untitaker untitaker requested review from a team as code owners January 17, 2025 17:55
@@ -17,7 +17,7 @@ repos:
- id: fix-encoding-pragma
args: ["--remove"]
- repo: https://github.com/pycqa/flake8
rev: 3.8.4
rev: 7.1.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

random change to fix my devenv

Comment on lines 682 to 687
self.__metrics.timing(
"arroyo.producer.produce_time",
time.time() - start_produce_time,
tags={"topic": message.topic()},
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WE should debounce this. Producing one metric per message will be a problem in talking to veneur it would impact the throughput of the consumer too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants