Addressing review feedback

getsentry · Nov 11, 2024 · 4fd3b32 · 4fd3b32
1 parent a428874
commit 4fd3b32
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/devservices/commands/logs.py b/devservices/commands/logs.py
@@ -56,8 +56,8 @@ def logs(args: Namespace) -> None:
             service,
             "logs",
             mode_dependencies,
+            remote_dependencies,
             options=["-n", MAX_LOG_LINES],
-            remote_dependencies=remote_dependencies,
         )
     except DockerComposeError as dce:
         console.failure(f"Failed to get logs for {service.name}: {dce.stderr}")

diff --git a/devservices/commands/start.py b/devservices/commands/start.py
@@ -53,8 +53,8 @@ def start(args: Namespace) -> None:
                 service,
                 "up",
                 mode_dependencies,
-                ["-d"],
-                remote_dependencies=remote_dependencies,
+                remote_dependencies,
+                options=["-d"],
             )
         except DockerComposeError as dce:
             status.failure(f"Failed to start {service.name}: {dce.stderr}")

diff --git a/devservices/commands/status.py b/devservices/commands/status.py
@@ -85,8 +85,8 @@ def status(args: Namespace) -> None:
             service,
             "ps",
             mode_dependencies,
+            remote_dependencies,
             options=["--format", "json"],
-            remote_dependencies=remote_dependencies,
         )
     except DockerComposeError as dce:
         console.failure(f"Failed to get status for {service.name}: {dce.stderr}")

diff --git a/devservices/commands/stop.py b/devservices/commands/stop.py
@@ -60,7 +60,7 @@ def stop(args: Namespace) -> None:
                 service,
                 "down",
                 mode_dependencies,
-                remote_dependencies=remote_dependencies,
+                remote_dependencies,
             )
         except DockerComposeError as dce:
             status.failure(f"Failed to stop {service.name}: {dce.stderr}")

diff --git a/devservices/utils/docker_compose.py b/devservices/utils/docker_compose.py
@@ -224,8 +224,8 @@ def run_docker_compose_command(
     service: Service,
     command: str,
     mode_dependencies: list[str],
+    remote_dependencies: set[InstalledRemoteDependency],
     options: list[str] = [],
-    remote_dependencies: set[InstalledRemoteDependency] = set(),
 ) -> list[subprocess.CompletedProcess[str]]:
     relative_local_dependency_directory = os.path.relpath(
         os.path.join(DEVSERVICES_DEPENDENCIES_CACHE_DIR, DEPENDENCY_CONFIG_VERSION),