Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logging): Add debug mode #124

Closed
wants to merge 0 commits into from

Conversation

hubertdeng123
Copy link
Member

closes #123

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 37.93103% with 18 lines in your changes missing coverage. Please review.

Project coverage is 89.19%. Comparing base (8c3c767) to head (7345c49).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
devservices/utils/docker_compose.py 29.16% 17 Missing ⚠️
devservices/utils/dependencies.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   90.72%   89.19%   -1.53%     
==========================================
  Files          19       19              
  Lines         819      898      +79     
==========================================
+ Hits          743      801      +58     
- Misses         76       97      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated

```
export DEBUG=true
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are your thoughts on also providing an optional debug flag for certain commands. The use case I see is running a specific command, it failing, and wanting to do a one-off debug for that command without wanting to go through and adding an entire env var.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially explored this path, but realized that it required refactoring quite a bit of code to support if we wanted to pass down the debug arg downstream. I looked at the diff and made a judgement call that it wasn't worth the changes it required.

@hubertdeng123 hubertdeng123 deleted the hubertdeng123/add-debug-mode branch November 14, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add debug mode
2 participants