Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(docker-compose): Moving dependency logic out of docker compose #129

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

IanWoodard
Copy link
Member

Starting to reduce the complexity of the run_docker_compose_command by decoupling dependency installation logic.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.23%. Comparing base (f2cad41) to head (4fd3b32).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
devservices/utils/dependencies.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   90.96%   91.23%   +0.26%     
==========================================
  Files          19       19              
  Lines         874      878       +4     
==========================================
+ Hits          795      801       +6     
+ Misses         79       77       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanWoodard IanWoodard merged commit 8a145e1 into main Nov 11, 2024
14 checks passed
@IanWoodard IanWoodard deleted the iw/refactoring-docker-compose-deps branch November 11, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants