Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(server): introduce client name enum #4226

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Conversation

Litarnus
Copy link
Contributor

@Litarnus Litarnus commented Nov 6, 2024

Introduces an enum which allows us to have more fine grained control over which sdks are tagged

#skip-changelog

@Litarnus Litarnus marked this pull request as ready for review November 7, 2024 08:17
@Litarnus Litarnus requested a review from a team as a code owner November 7, 2024 08:17
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

relay-server/src/statsd.rs Outdated Show resolved Hide resolved
relay-server/src/endpoints/common.rs Outdated Show resolved Hide resolved
relay-server/src/statsd.rs Outdated Show resolved Hide resolved
@Litarnus Litarnus changed the title ref(server): introduce platform tag enum ref(server): introduce client name enum Nov 7, 2024
@Litarnus Litarnus requested a review from Dav1dde November 7, 2024 12:59
Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :shipit:

@Litarnus Litarnus merged commit 726be3f into master Nov 7, 2024
23 checks passed
@Litarnus Litarnus deleted the martinl/sdk-allowlist branch November 7, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants