fix(kafka): Validate schema in tests #4900
Open
+60
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
reviewed
Jul 4, 2025
tobias-wilfert
force-pushed
the
tobias-wilfert/fix/validate-kafka-schemas-in-tests
branch
from
ded3eab to
16b61e9
Compare
Dav1dde
approved these changes
Jul 7, 2025
| @@ -91,9 +91,33 @@ pub trait Message { | |||
| /// Serializes the message into its binary format. | |||
| /// | |||
| /// # Errors | |||
| /// Returns the [`ClientError::InvalidMsgPack`] or [`ClientError::InvalidJson`] if the | |||
| /// Returns the [`ClientError::InvalidMsgPack`] , [`ClientError::InvalidJson`] or [`ClientError::ProtobufEncodingFailed`] if the | |||
There was a problem hiding this comment.
Suggested change
| /// Returns the [`ClientError::InvalidMsgPack`] , [`ClientError::InvalidJson`] or [`ClientError::ProtobufEncodingFailed`] if the | |
| /// Returns the [`ClientError::InvalidMsgPack`], [`ClientError::InvalidJson`] or [`ClientError::ProtobufEncodingFailed`] if the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the logic surrounding the kafka-scheme-validation such that it is correctly validated during testing.
#skip-changelog