chore(preprod): Reimplement multiset icon parsing #2889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
trevor-e
approved these changes
Oct 29, 2025
| key.perform(Selector(("keyList"))), | ||
| to: UnsafeMutableRawPointer.self | ||
| ) | ||
| guard let rendition = createRendition(from: structuredThemeStore, keyList) else { |
There was a problem hiding this comment.
I think doing this in two passes makes sense, my only concern with this change is the performance since right now our ParsedAssets step is pretty slow. Is calling createRendition() twice expensive to do or should we cache those results?
There was a problem hiding this comment.
great suggestion , implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in #2879 I added the ability for us to collect multiset icons and have them included in the ParsedAssets folder / assets.json.
There were two problems:
AppIcon_Alt_Color_Red, we'd only pick up the first image (red-light-min.png) when really it contains three, all of which we want to consider when analyzing for insightsWith these changes, we now get all the images in the multisets and we save them as images