feat(build): Add CLI version metadata to build upload archives #2890
Conversation
|
| )?; | ||
| } | ||
|
|
||
| let options = SimpleFileOptions::default() |
There was a problem hiding this comment.
These are the same options as set in upload.rs (scroll up further in the file to see it)
Adds a `.sentry-cli-metadata.txt` file to all zip archives created during build uploads. This file contains the sentry-cli version for debugging purposes. The metadata file is added to both single-file uploads (APK, AAB) and directory uploads (XCArchive) with the same compression and timestamp settings as other files to maintain consistent checksums. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
runningcode
force-pushed
the
no/add-cli-version-to-build-uploads
branch
from
9d2ccb4 to
caff448
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| let options = SimpleFileOptions::default() | ||
| .compression_method(zip::CompressionMethod::Deflated) | ||
| .last_modified_time(DateTime::default()); |
There was a problem hiding this comment.
Bug: Compression Inconsistency Causes Checksum Mismatch
The .sentry-cli-metadata.txt file is compressed with Deflated in normalize.rs but Stored in upload.rs. This inconsistency violates the intended goal of uniform compression and timestamp settings, which affects checksum consistency across different upload types.
| ? success | ||
| WARN [..] EXPERIMENTAL: The build subcommand is experimental. The command is subject to breaking changes and may be removed without notice in any release. | ||
| > Preparing for upload completed in [..] | ||
| > Uploading completed in [..] |
There was a problem hiding this comment.
m: I don't see why this line of output is disappearing following this change; I would expect that it should stay the same.
Please double-check why this is changing, and whether the change is intentional.
| zip.start_file(".sentry-cli-metadata.txt", options)?; | ||
| writeln!(zip, "sentry-cli-version: {VERSION}")?; |
There was a problem hiding this comment.
l: To ensure we always generate the version information in the same way, I would suggest we extract this logic to a separate method, that we can also reuse in the commands/build/upload.rs file
|
|
||
| ## Unreleased | ||
|
|
||
| ### Various fixes & improvements |
There was a problem hiding this comment.
| ### Various fixes & improvements | |
| ### Features |
|
|
||
| ### Various fixes & improvements | ||
|
|
||
| - Add CLI version metadata to build upload archives for debugging purposes ([#2890](https://github.com/getsentry/sentry-cli/pull/2890)) |
There was a problem hiding this comment.
Please add more details to this changelog entry, specifically so that users understand the user-facing changes. I have been making user-readable changelog entries a priority in the last few Sentry CLI releases.
| > Uploading completed in [..] | ||
| Successfully uploaded 1 file to Sentry | ||
| - tests/integration/_fixtures/build/apk.apk (http[..]/wat-org/preprod/wat-project/42) | ||
| - tests/integration/_fixtures/build/apk.apk (http://sentry.io/wat-org/preprod/wat-project/42) |
There was a problem hiding this comment.
In any case, this line should remain the same
| - tests/integration/_fixtures/build/apk.apk (http://sentry.io/wat-org/preprod/wat-project/42) | |
| - tests/integration/_fixtures/build/apk.apk (http[..]/wat-org/preprod/wat-project/42) |
Summary
Adds CLI version metadata to all zip archives created during build uploads for debugging purposes.
Resolves EME-471
Changes
.sentry-cli-metadata.txtfile at the root of each build upload zip archivesentry-cli-version: <version>🤖 Generated with Claude Code