Skip to content

feat: Validate single occurence of Sentry SDK inbinaries #5298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 61 commits into from
Jul 22, 2025

Bump diffMax to 885kb

62a7835
Select commit
Loading
Failed to load commit list.
Merged

feat: Validate single occurence of Sentry SDK inbinaries #5298

Bump diffMax to 885kb
62a7835
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 22, 2025 in 0s

86.463% (-0.209%) compared to 94a6b1a

View this Pull Request on Codecov

86.463% (-0.209%) compared to 94a6b1a

Details

Codecov Report

Attention: Patch coverage is 98.63014% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.463%. Comparing base (94a6b1a) to head (62a7835).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Swift/Tools/LoadValidator.swift 98.412% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5298       +/-   ##
=============================================
- Coverage   86.671%   86.463%   -0.209%     
=============================================
  Files          419       419               
  Lines        35864     35769       -95     
  Branches     16923     15175     -1748     
=============================================
- Hits         31084     30927      -157     
- Misses        4498      4802      +304     
+ Partials       282        40      -242     
Files with missing lines Coverage Δ
Sources/Sentry/SentryBinaryImageCache.m 100.000% <100.000%> (ø)
Sources/Sentry/SentrySDK.m 88.028% <100.000%> (ø)
Sources/Swift/Tools/LoadValidator.swift 98.412% <98.412%> (ø)

... and 58 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94a6b1a...62a7835. Read the comment docs.