Merged
Conversation
ccf3791 to
365d42e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5329 +/- ##
=============================================
+ Coverage 86.025% 86.027% +0.002%
=============================================
Files 397 397
Lines 34584 34589 +5
Branches 14972 14957 -15
=============================================
+ Hits 29751 29756 +5
+ Misses 4791 4789 -2
- Partials 42 44 +2
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e4cc043 | 1230.10 ms | 1254.36 ms | 24.26 ms |
| 103d817 | 1211.55 ms | 1213.35 ms | 1.80 ms |
| 983de17 | 1260.57 ms | 1263.68 ms | 3.11 ms |
| e070f8a | 1236.47 ms | 1250.50 ms | 14.03 ms |
| afce5bf | 1199.94 ms | 1213.27 ms | 13.33 ms |
| b9b0f0a | 1257.22 ms | 1262.57 ms | 5.35 ms |
| 60bfc91 | 1251.29 ms | 1261.67 ms | 10.39 ms |
| 3fc6a6f | 1241.96 ms | 1254.13 ms | 12.17 ms |
| 6e625c5 | 1243.47 ms | 1243.58 ms | 0.11 ms |
| 2deb275 | 1228.20 ms | 1245.02 ms | 16.82 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e4cc043 | 22.85 KiB | 414.92 KiB | 392.07 KiB |
| 103d817 | 21.58 KiB | 571.91 KiB | 550.33 KiB |
| 983de17 | 22.84 KiB | 403.19 KiB | 380.34 KiB |
| e070f8a | 21.58 KiB | 546.20 KiB | 524.62 KiB |
| afce5bf | 21.58 KiB | 542.18 KiB | 520.60 KiB |
| b9b0f0a | 20.76 KiB | 434.94 KiB | 414.17 KiB |
| 60bfc91 | 20.76 KiB | 434.94 KiB | 414.18 KiB |
| 3fc6a6f | 22.30 KiB | 821.37 KiB | 799.07 KiB |
| 6e625c5 | 22.85 KiB | 413.41 KiB | 390.56 KiB |
| 2deb275 | 21.58 KiB | 681.72 KiB | 660.14 KiB |
Previous results on branch: experimentalOptionsOnlySwift
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0bceca4 | 1220.57 ms | 1243.64 ms | 23.07 ms |
| 0743827 | 1220.46 ms | 1242.37 ms | 21.91 ms |
| 991861a | 1229.98 ms | 1251.08 ms | 21.10 ms |
| ebc9d20 | 1235.54 ms | 1246.39 ms | 10.85 ms |
| a8d141f | 1228.21 ms | 1251.68 ms | 23.47 ms |
| d0c8691 | 1230.51 ms | 1243.77 ms | 13.26 ms |
| 66f760c | 1211.69 ms | 1232.22 ms | 20.54 ms |
| fa2c9b4 | 1218.28 ms | 1240.78 ms | 22.50 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0bceca4 | 23.75 KiB | 841.34 KiB | 817.60 KiB |
| 0743827 | 23.75 KiB | 841.40 KiB | 817.65 KiB |
| 991861a | 23.76 KiB | 831.30 KiB | 807.54 KiB |
| ebc9d20 | 23.76 KiB | 837.47 KiB | 813.71 KiB |
| a8d141f | 23.76 KiB | 836.52 KiB | 812.76 KiB |
| d0c8691 | 23.76 KiB | 831.30 KiB | 807.54 KiB |
| 66f760c | 23.75 KiB | 841.58 KiB | 817.83 KiB |
| fa2c9b4 | 23.75 KiB | 841.58 KiB | 817.84 KiB |
365d42e to
c08c7b4
Compare
philipphofmann
approved these changes
Jun 2, 2025
294307a to
e63030c
Compare
e63030c to
ad32dbb
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in the SPM migration doc, this moves a Swift type from the objc interface into an extension, making it visible from Swift in SPM. It unfortunately requires the force cast, but I think is very safe and the public API does not change, which is why none of the call-sites of these properties had to change.
The objc property is
readonlyso we don't have to worry about it being set anywhere to an incorrect object, other than inSentryOptions.mitself which only sets it one time.I verified the objc interface does not change using the sample app, which access this property when configuring options. It's part of the iOS-ObjectiveC sample already
#skip-changelog