Skip to content

Full spm #5359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Full spm #5359

wants to merge 2 commits into from

Conversation

noahsmartin
Copy link
Contributor

POC with remaining changes needed to support building from SPM

#skip-changelog

@noahsmartin noahsmartin force-pushed the fullSPM branch 4 times, most recently from d48f968 to 5aec00b Compare June 5, 2025 03:40
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 11.11111% with 24 lines in your changes missing coverage. Please review.

Project coverage is 8.313%. Comparing base (fc000c8) to head (5bb09c5).

Files with missing lines Patch % Lines
...es/Swift/Protocol/Codable/SentryEventCodable.swift 0.000% 8 Missing ⚠️
Sources/Swift/Helper/Options+Swift.swift 0.000% 5 Missing ⚠️
...Integrations/SessionReplay/SentryReplayEvent.swift 33.333% 4 Missing ⚠️
...wift/Protocol/Codable/SentryExceptionCodable.swift 0.000% 2 Missing ⚠️
...wift/Protocol/Codable/SentryMechanismCodable.swift 0.000% 1 Missing ⚠️
.../Protocol/Codable/SentryMechanismMetaCodable.swift 0.000% 1 Missing ⚠️
...ift/Protocol/Codable/SentryStacktraceCodable.swift 0.000% 1 Missing ⚠️
...s/Swift/Protocol/Codable/SentryThreadCodable.swift 0.000% 1 Missing ⚠️
...ces/Swift/Protocol/Codable/SentryUserCodable.swift 0.000% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (fc000c8) and HEAD (5bb09c5). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (fc000c8) HEAD (5bb09c5)
4 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main    #5359        +/-   ##
=============================================
- Coverage   86.013%   8.313%   -77.701%     
=============================================
  Files          397      366        -31     
  Lines        34590    26765      -7825     
  Branches     14979       57     -14922     
=============================================
- Hits         29752     2225     -27527     
- Misses        4796    24540     +19744     
+ Partials        42        0        -42     
Files with missing lines Coverage Δ
Sources/Sentry/SentryOptions.m 38.997% <100.000%> (-59.764%) ⬇️
Sources/Sentry/SentryTransportAdapter.m 16.923% <ø> (-83.077%) ⬇️
...ift/Protocol/Codable/SentryBreadcrumbCodable.swift 0.000% <ø> (-100.000%) ⬇️
...wift/Protocol/Codable/SentryDebugMetaCodable.swift 0.000% <ø> (-100.000%) ⬇️
...es/Swift/Protocol/Codable/SentryFrameCodable.swift 0.000% <ø> (-100.000%) ⬇️
...rces/Swift/Protocol/Codable/SentryGeoCodable.swift 0.000% <ø> (-100.000%) ⬇️
Sources/Swift/Protocol/Codable/SentryMessage.swift 0.000% <ø> (-100.000%) ⬇️
.../Swift/Protocol/Codable/SentryNSErrorCodable.swift 0.000% <ø> (-100.000%) ⬇️
.../Swift/Protocol/Codable/SentryRequestCodable.swift 0.000% <ø> (-100.000%) ⬇️
...wift/Protocol/Codable/SentryMechanismCodable.swift 0.000% <0.000%> (-100.000%) ⬇️
... and 8 more

... and 374 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc000c8...5bb09c5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Jun 5, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1215.57 ms 1235.41 ms 19.84 ms
Size 23.75 KiB 845.89 KiB 822.14 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e4cc043 1230.10 ms 1254.36 ms 24.26 ms
103d817 1211.55 ms 1213.35 ms 1.80 ms
983de17 1260.57 ms 1263.68 ms 3.11 ms
e070f8a 1236.47 ms 1250.50 ms 14.03 ms
afce5bf 1199.94 ms 1213.27 ms 13.33 ms
b9b0f0a 1257.22 ms 1262.57 ms 5.35 ms
60bfc91 1251.29 ms 1261.67 ms 10.39 ms
3fc6a6f 1241.96 ms 1254.13 ms 12.17 ms
6e625c5 1243.47 ms 1243.58 ms 0.11 ms
2deb275 1228.20 ms 1245.02 ms 16.82 ms

App size

Revision Plain With Sentry Diff
e4cc043 22.85 KiB 414.92 KiB 392.07 KiB
103d817 21.58 KiB 571.91 KiB 550.33 KiB
983de17 22.84 KiB 403.19 KiB 380.34 KiB
e070f8a 21.58 KiB 546.20 KiB 524.62 KiB
afce5bf 21.58 KiB 542.18 KiB 520.60 KiB
b9b0f0a 20.76 KiB 434.94 KiB 414.17 KiB
60bfc91 20.76 KiB 434.94 KiB 414.18 KiB
3fc6a6f 22.30 KiB 821.37 KiB 799.07 KiB
6e625c5 22.85 KiB 413.41 KiB 390.56 KiB
2deb275 21.58 KiB 681.72 KiB 660.14 KiB

Previous results on branch: fullSPM

Startup times

Revision Plain With Sentry Diff
e98329b 1222.79 ms 1243.00 ms 20.21 ms

App size

Revision Plain With Sentry Diff
e98329b 23.76 KiB 841.88 KiB 818.12 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant