Skip to content

ci: Use common UI test action #5375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 9, 2025
Merged

Conversation

itaybre
Copy link
Contributor

@itaybre itaybre commented Jun 5, 2025

📜 Description

Creates a unified workflow to use from all our UI tests

💡 Motivation and Context

All our UI tests are running the same steps (or very similar), meaning that any change there need to be replicated multiple times, making it harder to maintain. Using a single workflow will help maintaining this workflow.

💚 How did you test it?

Run CI workflows

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@itaybre itaybre marked this pull request as ready for review June 6, 2025 04:04
Copy link
Member

@armcknight armcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! Please also add .github/workflows/ui-tests-common.yml to the list of trigger files in .github/workflows/ui-tests.yml

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.022%. Comparing base (e25f701) to head (3f36e06).
Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5375       +/-   ##
=============================================
+ Coverage   85.966%   86.022%   +0.055%     
=============================================
  Files          394       397        +3     
  Lines        34211     34583      +372     
  Branches     14778     14972      +194     
=============================================
+ Hits         29410     29749      +339     
- Misses        4761      4787       +26     
- Partials        40        47        +7     

see 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e25f701...3f36e06. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Jun 6, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1231.04 ms 1258.81 ms 27.77 ms
Size 23.75 KiB 840.58 KiB 816.83 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7bc3c0d 1261.16 ms 1278.38 ms 17.22 ms
621ba9b 1190.66 ms 1230.84 ms 40.18 ms
b9b0f0a 1235.61 ms 1237.40 ms 1.79 ms
fc350a4 1240.47 ms 1263.45 ms 22.98 ms
216bdf9 1196.29 ms 1209.80 ms 13.51 ms
de3c570 1219.76 ms 1241.67 ms 21.91 ms
3cba0e8 1231.20 ms 1251.50 ms 20.30 ms
a176fc4 1226.24 ms 1247.50 ms 21.26 ms
1928267 1200.94 ms 1227.17 ms 26.23 ms
e8c8a05 1218.71 ms 1234.50 ms 15.79 ms

App size

Revision Plain With Sentry Diff
7bc3c0d 20.76 KiB 427.36 KiB 406.59 KiB
621ba9b 20.76 KiB 414.45 KiB 393.69 KiB
b9b0f0a 20.76 KiB 434.93 KiB 414.17 KiB
fc350a4 21.90 KiB 708.34 KiB 686.44 KiB
216bdf9 21.58 KiB 418.13 KiB 396.54 KiB
de3c570 21.58 KiB 696.04 KiB 674.46 KiB
3cba0e8 22.84 KiB 403.18 KiB 380.34 KiB
a176fc4 22.84 KiB 403.24 KiB 380.39 KiB
1928267 22.30 KiB 730.78 KiB 708.47 KiB
e8c8a05 21.58 KiB 683.51 KiB 661.92 KiB

Previous results on branch: itaybre/composite_action_ui_tests

Startup times

Revision Plain With Sentry Diff
a404465 1234.10 ms 1260.15 ms 26.04 ms

App size

Revision Plain With Sentry Diff
a404465 23.75 KiB 840.59 KiB 816.84 KiB

@itaybre itaybre merged commit b3d0285 into main Jun 9, 2025
87 of 93 checks passed
@itaybre itaybre deleted the itaybre/composite_action_ui_tests branch June 9, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants