-
-
Notifications
You must be signed in to change notification settings - Fork 356
ci: Use common UI test action #5375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…/composite_action_ui_tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement! Please also add .github/workflows/ui-tests-common.yml
to the list of trigger files in .github/workflows/ui-tests.yml
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5375 +/- ##
=============================================
+ Coverage 85.966% 86.022% +0.055%
=============================================
Files 394 397 +3
Lines 34211 34583 +372
Branches 14778 14972 +194
=============================================
+ Hits 29410 29749 +339
- Misses 4761 4787 +26
- Partials 40 47 +7 see 19 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7bc3c0d | 1261.16 ms | 1278.38 ms | 17.22 ms |
621ba9b | 1190.66 ms | 1230.84 ms | 40.18 ms |
b9b0f0a | 1235.61 ms | 1237.40 ms | 1.79 ms |
fc350a4 | 1240.47 ms | 1263.45 ms | 22.98 ms |
216bdf9 | 1196.29 ms | 1209.80 ms | 13.51 ms |
de3c570 | 1219.76 ms | 1241.67 ms | 21.91 ms |
3cba0e8 | 1231.20 ms | 1251.50 ms | 20.30 ms |
a176fc4 | 1226.24 ms | 1247.50 ms | 21.26 ms |
1928267 | 1200.94 ms | 1227.17 ms | 26.23 ms |
e8c8a05 | 1218.71 ms | 1234.50 ms | 15.79 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7bc3c0d | 20.76 KiB | 427.36 KiB | 406.59 KiB |
621ba9b | 20.76 KiB | 414.45 KiB | 393.69 KiB |
b9b0f0a | 20.76 KiB | 434.93 KiB | 414.17 KiB |
fc350a4 | 21.90 KiB | 708.34 KiB | 686.44 KiB |
216bdf9 | 21.58 KiB | 418.13 KiB | 396.54 KiB |
de3c570 | 21.58 KiB | 696.04 KiB | 674.46 KiB |
3cba0e8 | 22.84 KiB | 403.18 KiB | 380.34 KiB |
a176fc4 | 22.84 KiB | 403.24 KiB | 380.39 KiB |
1928267 | 22.30 KiB | 730.78 KiB | 708.47 KiB |
e8c8a05 | 21.58 KiB | 683.51 KiB | 661.92 KiB |
📜 Description
Creates a unified workflow to use from all our UI tests
💡 Motivation and Context
All our UI tests are running the same steps (or very similar), meaning that any change there need to be replicated multiple times, making it harder to maintain. Using a single workflow will help maintaining this workflow.
💚 How did you test it?
Run CI workflows
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.