-
-
Notifications
You must be signed in to change notification settings - Fork 377
chore: Check AppKit linkage macOS #7343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7343 +/- ##
=============================================
- Coverage 85.714% 85.241% -0.473%
=============================================
Files 475 475
Lines 28560 28560
Branches 12411 12410 -1
=============================================
- Hits 24480 24345 -135
- Misses 4031 4171 +140
+ Partials 49 44 -5 see 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2f28bda | 1221.21 ms | 1255.09 ms | 33.88 ms |
| 48d9349 | 1226.57 ms | 1253.42 ms | 26.84 ms |
| 1b74fd4 | 1219.43 ms | 1250.17 ms | 30.73 ms |
| b5c1b24 | 1217.94 ms | 1248.76 ms | 30.82 ms |
| d52e416 | 1209.02 ms | 1239.56 ms | 30.53 ms |
| d8db577 | 1206.83 ms | 1244.39 ms | 37.56 ms |
| 41b4993 | 1215.15 ms | 1248.14 ms | 32.99 ms |
| 5a4353f | 1208.10 ms | 1240.50 ms | 32.40 ms |
| 99e17bb | 1218.50 ms | 1243.91 ms | 25.41 ms |
| 2c4362a | 1231.50 ms | 1255.95 ms | 24.45 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2f28bda | 24.14 KiB | 1.05 MiB | 1.03 MiB |
| 48d9349 | 24.14 KiB | 1.07 MiB | 1.04 MiB |
| 1b74fd4 | 24.14 KiB | 1.10 MiB | 1.08 MiB |
| b5c1b24 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| d52e416 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| d8db577 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 41b4993 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 5a4353f | 24.14 KiB | 1.07 MiB | 1.04 MiB |
| 99e17bb | 24.14 KiB | 1.09 MiB | 1.06 MiB |
| 2c4362a | 24.14 KiB | 1.07 MiB | 1.04 MiB |
|
Once we merge #7355, this check should pass |
📜 Description
Add a CI check to verify if our macOS build is linking with AppKit
💡 Motivation and Context
After doing some checks, looks like we are linking against AppKit when SENTRY_NO_UIKit is enabled, despite the framework name seeming like we don't.

This check will help us verify we don't link again after fixing it.
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.