Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Feb 3, 2026

📜 Description

Add a CI check to verify if our macOS build is linking with AppKit

💡 Motivation and Context

After doing some checks, looks like we are linking against AppKit when SENTRY_NO_UIKit is enabled, despite the framework name seeming like we don't.
image

This check will help us verify we don't link again after fixing it.

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • In_foreground and is_active app context by philipphofmann in #7188

Internal Changes 🔧

  • Check AppKit linkage macOS by itaybre in #7343
  • Update GA workflow to use reat native branch with v9 by itaybre in #7342
  • ObjC Integration cleanup by itaybre in #7320

🤖 This preview updates automatically when you update the PR.

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Feb 3, 2026
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.241%. Comparing base (741968b) to head (e48a9b8).
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #7343       +/-   ##
=============================================
- Coverage   85.714%   85.241%   -0.473%     
=============================================
  Files          475       475               
  Lines        28560     28560               
  Branches     12411     12410        -1     
=============================================
- Hits         24480     24345      -135     
- Misses        4031      4171      +140     
+ Partials        49        44        -5     

see 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 741968b...e48a9b8. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • .github/file-filters.yml

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.40 ms 1253.95 ms 34.56 ms
Size 24.14 KiB 1.09 MiB 1.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2f28bda 1221.21 ms 1255.09 ms 33.88 ms
48d9349 1226.57 ms 1253.42 ms 26.84 ms
1b74fd4 1219.43 ms 1250.17 ms 30.73 ms
b5c1b24 1217.94 ms 1248.76 ms 30.82 ms
d52e416 1209.02 ms 1239.56 ms 30.53 ms
d8db577 1206.83 ms 1244.39 ms 37.56 ms
41b4993 1215.15 ms 1248.14 ms 32.99 ms
5a4353f 1208.10 ms 1240.50 ms 32.40 ms
99e17bb 1218.50 ms 1243.91 ms 25.41 ms
2c4362a 1231.50 ms 1255.95 ms 24.45 ms

App size

Revision Plain With Sentry Diff
2f28bda 24.14 KiB 1.05 MiB 1.03 MiB
48d9349 24.14 KiB 1.07 MiB 1.04 MiB
1b74fd4 24.14 KiB 1.10 MiB 1.08 MiB
b5c1b24 24.14 KiB 1.06 MiB 1.04 MiB
d52e416 24.14 KiB 1.04 MiB 1.02 MiB
d8db577 24.14 KiB 1.06 MiB 1.04 MiB
41b4993 24.14 KiB 1.06 MiB 1.04 MiB
5a4353f 24.14 KiB 1.07 MiB 1.04 MiB
99e17bb 24.14 KiB 1.09 MiB 1.06 MiB
2c4362a 24.14 KiB 1.07 MiB 1.04 MiB

@itaybre
Copy link
Contributor Author

itaybre commented Feb 3, 2026

Once we merge #7355, this check should pass

@itaybre itaybre marked this pull request as ready for review February 3, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants