-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add screenshot feature description for Unreal Engine #11042
Conversation
@tustanivsky is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Looks OK to me but you might want @lizokm's review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments, but otherwise this looks good. Thanks for adding!
platform-includes/enriching-events/attach-screenshots/unreal.mdx
Outdated
Show resolved
Hide resolved
platform-includes/enriching-events/attach-screenshots/unreal.mdx
Outdated
Show resolved
Hide resolved
platform-includes/enriching-events/attach-screenshots/unreal.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Thank you, I've updated the PR according to the above suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ivan
I've already approved the Vercel build but seems stuck. cc @lizokm any tips? |
Do you happen to have any updates on this? I suppose we should be ready to proceed with the merge |
Hi there, the docs team is focusing on other priorities at the moment, so it may take us another week or more to get to this PR. If you need us to review this sooner, please let us know so we can prioritize accordingly. Thanks for your patience! |
Since the Unreal Engine SDK consists of multiple SDKs, the specific mechanism with which a screenshot is captured will vary depending on where the error originated. | ||
|
||
- On Windows/Linux, errors from within your game will be captured using the Unreal Engine API. This means that screenshots will only contain what's visible within your game. Any overlays on top of your game won't be visible. | ||
- On Apple/Android, screenshots will be captured using platform APIs. If you're using a native plugin to display an overlay and an error occurs, the SDK will try to capture a screenshot that contains the overlay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could clarify that it's still limited to the actual game app and not "anything that's an overlay on the screen".
platform-includes/enriching-events/attach-screenshots/unreal.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This PR adds screenshot capturing feature description for Unreal Engine SDK.