-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(nuxt): Add docs for Cloudflare Nitro plugin #14219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 865.2kB (4.1%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
docs/platforms/javascript/guides/cloudflare/frameworks/nuxt.mdx
Outdated
Show resolved
Hide resolved
Delete `sentry.server.config.ts` if it exists. | ||
|
||
2. **Add a Nitro plugin:** | ||
Create a new file in `server/plugins` (for example, `server/plugins/sentry-cloudflare-setup.ts`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: should we just be more opinionated here and just tell users to name it sentry-cloudflare-setup.ts
?
Then we could consolidate step 2 and 3 together:
- Create a Nitro plugin:
Createsentry-cloudflare-setup.ts
inserver/plugins
:
<code snippet here>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as comment above: #14219 (comment)
The file name does not matter but it's indeed smart to have one step less. If we want to write a filename to the docs, we could name it sentry.cloudflare.config.ts
to be in line with sentry.server.config.ts
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just call it sentry-cloudflare-plugin.ts
, seems most sensible to me. Naming it sentry.cloudflare.config.ts
makes me think it would just need a Sentry.init in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐳!
I added some suggestions
DESCRIBE YOUR PR
Docs for getsentry/sentry-javascript#15597
closes getsentry/sentry-javascript#16780
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: