Skip to content

proposed updates for flagsmith integration docs #14225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Jul 1, 2025

Merge into #14126 (external PR)

Copy link

vercel bot commented Jul 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2025 9:36pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Jul 1, 2025 9:36pm

@aliu39 aliu39 marked this pull request as draft July 1, 2025 21:24
Comment on lines +11 to +15
### Set Up Evaluation Tracking

Flagsmith recommends using a OpenFeature SDK and [Flagsmith Provider](https://openfeature.dev/ecosystem?instant_search%5Bquery%5D=flagsmith&instant_search%5BrefinementList%5D%5Btype%5D%5B0%5D=Provider) to evaluate feature flags. To track these evaluations, visit one of our supported languages pages for OpenFeature:
* [JavaScript](/platforms/javascript/configuration/integrations/openfeature/)
* [Python](/platforms/python/integrations/openfeature/)
Copy link
Member Author

@aliu39 aliu39 Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only changed content for this file. The rest can stay the same, other than sidebar_order: 1

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Flagsmith Integration: Missing Save Step

The Flagsmith integration documentation contains two issues in the "Set Up Change Tracking" section:

  1. Step 1 incorrectly instructs users to "Select Generic in the dropdown that says 'Select a provider'". This should either be "Select Flagsmith" or include an explanation if "Generic" is the intended selection for Flagsmith integration.
  2. Step 3, "Set the Signing Secret", omits an explicit instruction to save the configuration, only stating "Once saved" without detailing the save action.

docs/organization/integrations/feature-flag/flagsmith/index.mdx#L26-L37

- One webhook secret can be registered per provider type.
- Select Generic in the dropdown that says "Select a provider".
2. **Register the webhook URL**.
- Go to your Flagsmith project dashboard and navigate to the `/project/:projectid/integrations` page, which can be found by clicking "Integrations" on the top navigation bar.
- Find the Sentry option, and click "Add Integration", which will open a modal.
- Select the Environment from which flag change events will trigger.
- Copy the provided Sentry webhook URL and paste it into "Webhook URL" in the Flagsmith "Sentry Integration" modal.
3. **Set the Signing Secret**.
- Still in the Flagsmith "Sentry Integration" modal, type in any string between 10 and 60 characters to use as your authorization token ("secret").
- Copy the authorization token from the previous step and paste it into the input box next to "Secret" in Sentry settings.
Once saved, Sentry will now accept and authenticate all inbound hooks to your organization's feature flag webhook endpoint.

Fix in Cursor


BugBot free trial expires on July 22, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

Copy link

codecov bot commented Jul 1, 2025

Bundle Report

Changes will increase total bundle size by 860.64kB (4.08%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.8MB 860.64kB (7.87%) ⬆️
sentry-docs-client-array-push 9.8MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 873.24kB -0.0%
static/chunks/7750-*.js -3 bytes 415.85kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/jqly7nB4S5Ap7l8aLABqr/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/jqly7nB4S5Ap7l8aLABqr/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/K3yK1FYCJaH9ocMPUtMtS/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/K3yK1FYCJaH9ocMPUtMtS/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.64MB -0.0%
../instrumentation.js -3 bytes 973.36kB -0.0%
9523.js -3 bytes 949.31kB -0.0%
../app/[[...path]]/page.js.nft.json 286.88kB 691.29kB 70.94% ⚠️
../app/platform-redirect/page.js.nft.json 286.88kB 691.2kB 70.96% ⚠️
../app/sitemap.xml/route.js.nft.json 286.88kB 689.17kB 71.31% ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant