Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| // SENTRY_API_SCHEMA_SHA is used in the sentry-docs GHA workflow in getsentry/sentry-api-schema. | ||
| // DO NOT change variable name unless you change it in the sentry-docs GHA workflow in getsentry/sentry-api-schema. | ||
| const SENTRY_API_SCHEMA_SHA = '0583755a815d16d432791204c3547c39483345d6'; | ||
| const SENTRY_API_SCHEMA_SHA = 'ddda95066e1e5469719906060605f9fec04010e5'; |
There was a problem hiding this comment.
Bug: The code may crash in apiCategoriesUncached when an API uses a tag not defined in data.tags, leading to an attempt to access a property on undefined.
Severity: CRITICAL
Suggested Fix
Before pushing to the apis array within the apiData.tags.forEach loop, add a check to verify that categoryMap[tag] exists. If it does not, either skip the tag or log a warning to prevent the build from crashing.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: src/build/resolveOpenAPI.ts#L11
Potential issue: In the `apiCategoriesUncached` function, the code populates a
`categoryMap` using tags from `data.tags`. It then iterates through API endpoints and
their associated tags. If an API endpoint uses a tag that is not present in the initial
`data.tags` list, the code will attempt to access the `apis` property on an `undefined`
value (`categoryMap[tag]`). This will throw a `Cannot read properties of undefined
(reading 'apis')` error, causing the documentation build process to crash.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.