fix: incorrect use of SentryNative within a WASM app#3363
Merged
bitsandfoxes merged 11 commits intomainfrom May 13, 2024
Merged
fix: incorrect use of SentryNative within a WASM app#3363bitsandfoxes merged 11 commits intomainfrom
bitsandfoxes merged 11 commits intomainfrom
Conversation
Closed
bitsandfoxes
approved these changes
May 13, 2024
| else | ||
| { | ||
| #pragma warning restore CS0162 // Unreachable code detected | ||
| options.LogDebug("This doesn't look like a Native AOT application build."); |
Contributor
There was a problem hiding this comment.
I agree with the // TODO this probably more closely represents trimming rather than NativeAOT?. Enabling AOT compilation and then reading this in the logs does seem odd.
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- incorrect use of SentryNative within a WASM app ([#3363](https://github.com/getsentry/sentry-dotnet/pull/3363))If none of the above apply, you can opt out of this check by adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3263 by disabling sentry-native SDK init when running under WASM AOT.
Tested manually by running the Sentry.Samples.AspNetCore.Blazor.Wasm app produced by
dotnet publish -c Release. Proper tests could be part of #2021