Add functionality and tests for iOS mobile app upload #320

runningcode · 2025-06-13T13:18:17Z

This calls sentry-cli mobile-app upload with a path to the xcarchive.
The lane looks like this (also documented in README):

sentry_upload_mobile_app(
  api_key: '...', # Do not use if using auth_token
  auth_token: '...', # Do not use if using api_key
  org_slug: '...',
  project_slug: '...',
  xcarchive_path: './build/MyApp.xcarchive', # Path to your .xcarchive file
)

The xcarchive_path is automatically inferred from SharedValue::XCODEBUILD_ARCHIVE and can be overridden.

See this internal doc for more details on the implementation of this feature: https://www.notion.so/sentry/1f68b10e4b5d80b1a127fb174f87c555

github-actions · 2025-06-13T13:19:14Z

	Fails
🚫	Please consider adding a changelog entry for the next release.

`Instructions and example for changelog`$

Please add an entry to CHANGELOG.md` to the "Unreleased" section under the following heading:

To the changelog entry, please add a link to this PR (consider a more descriptive message):`

- Add functionality and tests for iOS mobile app upload(#320)

If none of the above apply, you can opt out by adding _#skip-changelog_ to the PR description.

Generated by 🚫 dangerJS against a89b179

trevor-e · 2025-06-16T22:47:17Z

lib/fastlane/plugin/sentry/actions/sentry_upload_mobile_app.rb

+        Helper::SentryConfig.parse_api_params(params)
+
+        # Verify xcarchive path
+        xcarchive_path = params[:xcarchive_path]


In most cases the app will be built in a prior "lane" and can be re-used automatically. Check out what we did here: https://github.com/EmergeTools/fastlane-plugin-emerge/blob/main/lib/fastlane/plugin/emerge/actions/emerge_action.rb#L17-L26

good idea. i added this on line 42 as the default value.

trevor-e · 2025-06-16T22:48:52Z

lib/fastlane/plugin/sentry/actions/sentry_upload_mobile_app.rb

+      def self.available_options
+        Helper::SentryConfig.common_api_config_items + [
+          FastlaneCore::ConfigItem.new(key: :xcarchive_path,
+                                       env_name: "SENTRY_XCARCHIVE_PATH",


Similarly I'm not sure we need an env var for this if we are re-using the existing lane stuff.

lib/fastlane/plugin/sentry/actions/sentry_upload_mobile_app.rb

runningcode · 2025-06-13T14:20:52Z

CHANGELOG.md

@@ -251,7 +257,7 @@ We bumped the minimum sentry-cli version to `1.70.1` because it includes an esse

 ### Fixes

- fix: Upload Dif use '-' instead of '_' ([#99](https://github.com/getsentry/sentry-fastlane-plugin/pull/99))
+- fix: Upload Dif use '-' instead of '\_' ([#99](https://github.com/getsentry/sentry-fastlane-plugin/pull/99))


ignore this, cursor just reformatted it :’(

runningcode · 2025-06-13T14:20:55Z

README.md

- __include_sources__: Optional. Include sources from the local file system and upload them as source bundles.
- __wait__: Wait for the server to fully process uploaded files. Errors can only be displayed if --wait is specified, but this will significantly slow down the upload process.
- __upload_symbol_maps__: Optional. Upload any BCSymbolMap files found to allow Sentry to resolve hidden symbols, e.g. when it downloads dSYMs directly from App Store Connect or when you upload dSYMs without first resolving the hidden symbols using --symbol-maps.
+- **type**: Optional. Only consider debug information files of the given type. By default, all types are considered. Valid options: 'dsym', 'elf', 'breakpad', 'pdb', 'pe', 'sourcebundle', 'bcsymbolmap'.


ignore this, cursor just reformatted it :’(
i’ll undo this later.

lib/fastlane/plugin/sentry/actions/sentry_upload_mobile_app.rb

runningcode · 2025-06-17T08:32:25Z

README.md

+)
+```
+
+By default the `SharedValue::XCODEBUILD_ARCHIVE` sets the `xarchive_path` parameter if set by a prior lane.


@trevor-e does this make sense? I wasn’t sure of the proper lingo.

We could mention build_app as an example of a prior lane.

runningcode · 2025-06-17T08:32:46Z

lib/fastlane/plugin/sentry/actions/sentry_upload_mobile_app.rb

+        Helper::SentryConfig.parse_api_params(params)
+
+        # Verify xcarchive path
+        xcarchive_path = params[:xcarchive_path]


good idea. i added this on line 42 as the default value.

philprime

Would it be possible for us to do some sort of integration test with an actual app project? Do we have a project available to test it locally?

philprime · 2025-06-17T10:58:35Z

README.md

+)
+```
+
+By default the `SharedValue::XCODEBUILD_ARCHIVE` sets the `xarchive_path` parameter if set by a prior lane.


We could mention build_app as an example of a prior lane.

lib/fastlane/plugin/sentry/actions/sentry_upload_mobile_app.rb

runningcode · 2025-06-17T16:16:21Z

Regarding testing, I used the hackernews app built locally: https://github.com/EmergeTools/hackernews

You need to use the main branch of the sentry-cli and point the fastlane plugin to that via the SENTRY_CLI_PATH environment variable.

github-actions · 2025-07-09T00:00:29Z

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

philprime · 2025-07-23T07:30:32Z

Hey @runningcode, what's the status on this PR?

runningcode · 2025-07-23T08:16:19Z

We're waiting on two things,

The service to process the uploads being ready. Launchpad
The sentry-cli's mobile-app upload command being released.
This should happen in the next few weeks.

runningcode force-pushed the no/ios-mobile-upload branch 4 times, most recently from 2c731b8 to b3ec7ef Compare June 16, 2025 16:45

Add functionality and tests for iOS mobile app upload

fb98c92

runningcode force-pushed the no/ios-mobile-upload branch from b3ec7ef to fb98c92 Compare June 16, 2025 16:46

trevor-e reviewed Jun 16, 2025

View reviewed changes

runningcode force-pushed the no/ios-mobile-upload branch 5 times, most recently from ef6db2a to 59818d9 Compare June 17, 2025 08:27

Remove no upload and add default value

36e430c

runningcode force-pushed the no/ios-mobile-upload branch from 59818d9 to 36e430c Compare June 17, 2025 08:30

runningcode commented Jun 17, 2025

View reviewed changes

runningcode marked this pull request as ready for review June 17, 2025 08:33

runningcode requested review from philipphofmann and philprime as code owners June 17, 2025 08:33

philprime reviewed Jun 17, 2025

View reviewed changes

Address review comments

a89b179

github-actions bot added the Status: Stale label Jul 9, 2025

runningcode added Status: Backlog and removed Status: Stale labels Jul 9, 2025

Uh oh!

Add functionality and tests for iOS mobile app upload #320

Are you sure you want to change the base?

Add functionality and tests for iOS mobile app upload #320

Uh oh!

Conversation

runningcode commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

philprime left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

runningcode commented Jun 17, 2025

Uh oh!

github-actions bot commented Jul 9, 2025

Uh oh!

philprime commented Jul 23, 2025

Uh oh!

runningcode commented Jul 23, 2025

Uh oh!

Uh oh!

runningcode commented Jun 13, 2025 •

edited

Loading

github-actions bot commented Jun 13, 2025 •

edited

Loading