feat: Support skipping validating regions #127
Conversation
| @@ -14,7 +14,8 @@ | |||
|
|
|||
| @click.command() | |||
| @click.argument("filename", nargs=-1) | |||
| def test_services(filename: Sequence[str]) -> None: | |||
| @click.option("--skip-region", multiple=True) | |||
There was a problem hiding this comment.
Thoughts on adding a --region flag here?
I think it would be useful for us to be able to test our region in isolation too.
It would also let us move this to a matrix job in GHA and validate regions in parallel.
There was a problem hiding this comment.
We should avoid using this in general as per our Slack discussion, allowlisting also means that we'd be constantly updating this list when we added new regions. If speedrun hadn't completely broken our CI I'd be pushing back on this feature as a thing entirely.
There was a problem hiding this comment.
You can also locally limit your validation by the files you pass in, it's really only an issue in CI where we pass in *s
There was a problem hiding this comment.
I don't mean to switch it to allowlist for everything, but this would let me still use this to test speedrun2 and other regions easily, locally or in a separate job if needed.
Enable the ability to skip regions in the validation task.