-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: configurable _values.yaml merging #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there some examples of how this is expected to be used? Eg. within ops which services would use reject vs overwrite vs append? Which ones need alternate strategies (and why)?
Is there a good way for someone working on a service to understand which strategy the service is using?
What's the current behaviour? Is that changing?
I've updated the unit tests which will hopefully be illuminating. The defaults aren't changing here -- the default is still |
As far as someone working on a service understanding the strategy, it should be pretty obvious from looking at the default: reject
paths:
workers: append |
6f2dd92
to
1d7e529
Compare
1d7e529
to
c4cd1cd
Compare
Allow a service to add a metadata file from its root:
./sentry-kube/merge.yaml
, that specifies config for how conflicting keys should be handled. This enables behavior like having mappings in different files that can be merged in an append fashion.Fixes RELENG-3