Skip to content

[Logs 6] Reduce amount of locking on every created log event #4380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 13, 2025

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented May 8, 2025

#skip-changelog

📜 Description

Reduce amount of locking on every created log event

💡 Motivation and Context

Previously every created log event would acquire the lock to check if it had to schedule.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented May 8, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 88a1393

Copy link
Contributor

github-actions bot commented May 8, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 389.26 ms 407.10 ms 17.85 ms
Size 1.58 MiB 2.08 MiB 509.51 KiB

Previous results on branch: feat/log-batch-less-locking

Startup times

Revision Plain With Sentry Diff
d0b2842 405.51 ms 453.51 ms 48.00 ms

App size

Revision Plain With Sentry Diff
d0b2842 1.58 MiB 2.08 MiB 508.47 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer changed the title Reduce amount of locking on every created log event [Logs 6] Reduce amount of locking on every created log event May 12, 2025
Base automatically changed from feat/log-batching-separate-executor-service to main May 13, 2025 13:46
@adinauer adinauer merged commit 740abb1 into main May 13, 2025
33 of 34 checks passed
@adinauer adinauer deleted the feat/log-batch-less-locking branch May 13, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants