Skip to content

[Logs 11] Add severityNumber to SentryLogEvent #4391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
May 13, 2025
Merged

[Logs 11] Add severityNumber to SentryLogEvent #4391

merged 20 commits into from
May 13, 2025
+24 −0

Conversation

adinauer
Copy link
Member

#skip-changelog

📜 Description

Add severityNumber to SentryLogEvent

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 12, 2025 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c07e44c

@adinauer adinauer mentioned this pull request May 12, 2025
Merged
7 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 12, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 445.71 ms 540.35 ms 94.63 ms
Size 1.58 MiB 2.08 MiB 510.53 KiB

Previous results on branch: feat/logs-severity-number

Startup times

Revision Plain With Sentry Diff
e47c71b 421.40 ms 446.24 ms 24.85 ms

App size

Revision Plain With Sentry Diff
e47c71b 1.58 MiB 2.08 MiB 509.64 KiB

@adinauer adinauer changed the title [Logs 10] Add severityNumber to SentryLogEvent [Logs 11] Add severityNumber to SentryLogEvent May 12, 2025
Base automatically changed from feat/logs-not-experimental to main May 13, 2025 15:11
@adinauer adinauer enabled auto-merge (squash) May 13, 2025 15:14
@adinauer adinauer merged commit 87690fc into main May 13, 2025
33 checks passed
@adinauer adinauer deleted the feat/logs-severity-number branch May 13, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanosiano stefanosiano stefanosiano approved these changes

@lcian lcian lcian approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adinauer @stefanosiano @lcian