Skip to content

[Logs 12] Logs review feedback #4392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
May 13, 2025
Merged

[Logs 12] Logs review feedback #4392

merged 26 commits into from
May 13, 2025

Conversation

adinauer
Copy link
Member

#skip-changelog

📜 Description

Logs review feedback

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented May 12, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 7894f55

@adinauer adinauer changed the title [Logs 11] Logs review feedback [Logs 12] Logs review feedback May 12, 2025
Copy link
Contributor

github-actions bot commented May 12, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 428.94 ms 458.53 ms 29.59 ms
Size 1.58 MiB 2.08 MiB 510.52 KiB

Previous results on branch: feat/logs-review-feedback

Startup times

Revision Plain With Sentry Diff
fd1e114 397.53 ms 438.28 ms 40.75 ms

App size

Revision Plain With Sentry Diff
fd1e114 1.58 MiB 2.08 MiB 509.67 KiB

@stefanosiano
Copy link
Member

are you going to add the server address in another PR? Or even later after release, or was it just forgotten?

@adinauer
Copy link
Member Author

I will add it in a follow up PR, I'm OK with releasing without it.

@adinauer adinauer linked an issue May 13, 2025 that may be closed by this pull request
@adinauer adinauer mentioned this pull request May 13, 2025
7 tasks
Base automatically changed from feat/logs-severity-number to main May 13, 2025 15:27
@adinauer adinauer enabled auto-merge (squash) May 13, 2025 15:29
@adinauer adinauer merged commit ff3aa9c into main May 13, 2025
32 of 33 checks passed
@adinauer adinauer deleted the feat/logs-review-feedback branch May 13, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SentryLevel.TRACE
3 participants