Skip to content

fix(replay): Do not capture replay for cached events #4474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 6, 2025

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jun 5, 2025

📜 Description

While testing I noticed that we call captureReplay for errors that are coming from cache, which is wrong because those errors are from the past and should not affect the currently running replay.

💡 Motivation and Context

💚 How did you test it?

Manually + automated

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jun 5, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 431.51 ms 479.67 ms 48.16 ms
Size 1.58 MiB 2.08 MiB 511.11 KiB

Previous results on branch: rz/fix/session-replay-cached-events

Startup times

Revision Plain With Sentry Diff
23f5f5d 435.04 ms 497.35 ms 62.31 ms

App size

Revision Plain With Sentry Diff
23f5f5d 1.58 MiB 2.08 MiB 511.12 KiB

@romtsn romtsn merged commit 98f55ae into main Jun 6, 2025
32 of 34 checks passed
@romtsn romtsn deleted the rz/fix/session-replay-cached-events branch June 6, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants