-
-
Notifications
You must be signed in to change notification settings - Fork 461
build(deps): bump getsentry/github-workflows/.github/workflows/updater.yml from 2 to 3 #4884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| jobs: | ||
| native: | ||
| uses: getsentry/github-workflows/.github/workflows/updater.yml@v2 | ||
| uses: getsentry/github-workflows/.github/workflows/updater.yml@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: V3 Upgrade: Workflow Syntax Mismatch
The upgrade to v3 is incomplete. According to the breaking changes, v3 converted from reusable workflows to composite actions, requiring jobs to use runs-on and steps, change the path from .github/workflows/updater.yml to updater, and move api-token from secrets: to with:. The current syntax still uses the old reusable workflow format which no longer exists in v3, causing the workflow to fail.
|
|
||
| gradle-wrapper: | ||
| uses: getsentry/github-workflows/.github/workflows/updater.yml@v2 | ||
| uses: getsentry/github-workflows/.github/workflows/updater.yml@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Workflow Syntax Obsolete After Upgrade
The upgrade to v3 is incomplete. According to the breaking changes, v3 converted from reusable workflows to composite actions, requiring jobs to use runs-on and steps, change the path from .github/workflows/updater.yml to updater, and move api-token from secrets: to with:. The current syntax still uses the old reusable workflow format which no longer exists in v3, causing the workflow to fail.
| jobs: | ||
| native: | ||
| uses: getsentry/github-workflows/.github/workflows/updater.yml@v2 | ||
| uses: getsentry/github-workflows/.github/workflows/updater.yml@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The uses syntax for getsentry/github-workflows v3 is incorrect, referencing a non-existent path for the updater composite action.
Severity: CRITICAL | Confidence: 1.00
🔍 Detailed Analysis
The uses statement for getsentry/github-workflows specifies the old reusable workflow path getsentry/github-workflows/.github/workflows/updater.yml@v3. However, v3 of getsentry/github-workflows migrated updater to a composite action, which requires the syntax getsentry/github-workflows/updater@v3. GitHub Actions will fail to locate the resource at the specified path, causing the workflow execution to terminate. This affects both the native and gradle-wrapper jobs.
💡 Suggested Fix
Update the uses statements from getsentry/github-workflows/.github/workflows/updater.yml@v3 to getsentry/github-workflows/updater@v3 for both native and gradle-wrapper jobs.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/workflows/update-deps.yml#L14
Potential issue: The `uses` statement for `getsentry/github-workflows` specifies the old
reusable workflow path `getsentry/github-workflows/.github/workflows/updater.yml@v3`.
However, v3 of `getsentry/github-workflows` migrated `updater` to a composite action,
which requires the syntax `getsentry/github-workflows/updater@v3`. GitHub Actions will
fail to locate the resource at the specified path, causing the workflow execution to
terminate. This affects both the `native` and `gradle-wrapper` jobs.
Did we get this right? 👍 / 👎 to inform future reviews.
f6916c3 to
cb4c7cb
Compare
…r.yml Bumps [getsentry/github-workflows/.github/workflows/updater.yml](https://github.com/getsentry/github-workflows) from 2 to 3. - [Release notes](https://github.com/getsentry/github-workflows/releases) - [Changelog](https://github.com/getsentry/github-workflows/blob/main/CHANGELOG.md) - [Commits](getsentry/github-workflows@v2...v3) --- updated-dependencies: - dependency-name: getsentry/github-workflows/.github/workflows/updater.yml dependency-version: '3' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
cb4c7cb to
a01c67e
Compare
Bumps getsentry/github-workflows/.github/workflows/updater.yml from 2 to 3.
Release notes
Sourced from getsentry/github-workflows/.github/workflows/updater.yml's releases.
... (truncated)
Changelog
Sourced from getsentry/github-workflows/.github/workflows/updater.yml's changelog.
... (truncated)
Commits
13be9berelease: 3.1.00d0d99afeat(updater): Add SSH key support and comprehensive authentication validatio...6272a50chore(deps): update Danger JS to v13.0.4 (#132)71d223efix(updater): Pass OriginalTag to post-update script on second run (#133)0bd595fchore: Rename workflow to 'Update dependencies'1c10977chore: Use updater action to manage Danger JS version (#131)3182dd4feat(updater): Add post-update-script support (#130)15e4b10fix: Handle boolean inputs correctly and validate supported values (#127)c6471d1Merge branch 'release/3.0.0'342f5e2release: 3.0.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)