Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): Replace release bot with GH app #301

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

Jeffreyhung
Copy link
Member

The getsentry-release is a GitHub bot account that is used in various automation, and the ${{ secrets.GH_RELEASE_PAT }} is a personal access token from that bot account. We are using a regular GitHub account as a bot while it should be a non-human account since there are no humans behind it. Hence, we are replacing it with a GitHub App.

Functionality wise, there will be no difference.

More details: https://www.notion.so/sentry/DACI-Replace-GitHub-bot-accounts-with-GitHub-Apps-getsentry-release-15109965d1204a91b9be71c49e8b66e0?pvs=4

#skip-changelog

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 5a78c67

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.00%. Comparing base (d5983f7) to head (5a78c67).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #301   +/-   ##
=======================================
  Coverage   77.00%   77.00%           
=======================================
  Files          39       39           
  Lines         635      635           
  Branches       86       86           
=======================================
  Hits          489      489           
  Misses        100      100           
  Partials       46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jeffreyhung Jeffreyhung enabled auto-merge (squash) December 10, 2024 00:05
@Jeffreyhung Jeffreyhung requested a review from BYK December 10, 2024 23:53
@Jeffreyhung Jeffreyhung merged commit d3bf403 into main Dec 11, 2024
11 checks passed
@Jeffreyhung Jeffreyhung deleted the Replace-release-bot-with-GH-app branch December 11, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants