-
-
Notifications
You must be signed in to change notification settings - Fork 2
Support multiple source roots #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
26f7834
to
1308e01
Compare
Working on checking that the existing integration tests still pass and adding new tests. |
This PR should come after #142 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIce work!
Added a comment regarding try-with-resource
for the stream that is returned by Files.walk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM 👍
📜 Description
Adds support for multiple source roots.
Works similarly to our
sentry-android-gradle-plugin
:additionalSourceDirsForSourceContext
plugin parameter get copied totarget/sentry/collected-sources
sentry-cli
as normal💡 Motivation and Context
Closes #70
💚 How did you test it?
Tested manually with the sample project
📝 Checklist
🔮 Next steps
Document it