Skip to content

Support multiple source roots #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 8, 2025
Merged

Support multiple source roots #137

merged 13 commits into from
Apr 8, 2025

Conversation

lcian
Copy link
Member

@lcian lcian commented Mar 18, 2025

📜 Description

Adds support for multiple source roots.

Works similarly to our sentry-android-gradle-plugin:

  • The contents of the source roots (+ any additional dirs passed with the additionalSourceDirsForSourceContext plugin parameter get copied to target/sentry/collected-sources
  • Then they are bundled and sent by sentry-cli as normal

💡 Motivation and Context

Closes #70

💚 How did you test it?

Tested manually with the sample project

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

Document it

@lcian lcian force-pushed the lcian/feat/multiple-source-roots branch from 26f7834 to 1308e01 Compare March 18, 2025 10:33
@lcian lcian requested a review from lbloder March 18, 2025 14:37
@lcian lcian marked this pull request as draft March 21, 2025 10:36
@lcian
Copy link
Member Author

lcian commented Mar 21, 2025

Working on checking that the existing integration tests still pass and adding new tests.

@lcian
Copy link
Member Author

lcian commented Mar 21, 2025

This PR should come after #142

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce work!
Added a comment regarding try-with-resource for the stream that is returned by Files.walk

@lcian lcian marked this pull request as ready for review March 25, 2025 13:21
@lcian lcian requested a review from lbloder April 3, 2025 07:26
@lcian lcian linked an issue Apr 4, 2025 that may be closed by this pull request
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍

@lcian lcian merged commit c7fe84f into main Apr 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants